-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] CC: One PR to rule them all -- feature parity with old API #59
Conversation
978f18d
to
4bc9be7
Compare
@J08nY which fields from
|
So I only rendered a few things from the Even though I don't really use some of the others (only display the cert lab and cert lifetime length here: https://github.com/crocs-muni/sec-certs/blob/page/sec_certs/templates/cc/entry.html.jinja2#L121) I feel like they have value in the JSON export if the heuristics used to compute them are interesting. So I maybe wouldn't include something that can be computed as a simple subtraction of dates/years but I would include something that is computed non-trivially. |
- Cert_ids are now extracted - cert_id from frontpage is always preferred - If no frontpage cert_id is found, the most ocurring keyword is preferred - Some tests were revoked as heuristics should be computed after pdf processing
I've decided not to include the analogies of old-api fields:
I've manually went through approximately 200 certificates, only single of them had some non-trivial content in those fields. Their parsing is tricky, may trigger false positives if not careful enough and simply does not add any valuable information. I've noticed that the old API is used to draw some dot plots, are they of any use @petrs ? Created #73 new issue for that, in case we ever encounter a sensible use case for such functionality. |
@J08nY I was thinking about your request to process Maintenance updates along with CC certificates. It turned out to be quite tricky and makes the resulting JSON messy. I ended up with considering the following solution:
I prepared a small demo at ajanovsky.cz/test_maintenance.zip That way, we can still process all certificates and not make the CC json too messy. Do you mind having two different sources for your database on web? I can explain on the phone if I'm not clear enough. |
Description
Reaches feature parity with the old API with one exception -- analysis. The analyses will be replicated anyway and coded on-the-fly.
This PR implements
src
attribute serialization inCommonCriteriaCert
classmatched_string: absolute_frequency
Heuristics to compute
After short discussion with @J08nY, I'll be computing the following:
List of manufacturers -- and unify their naming across whole dataset