Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactoring: Split large files that cover multiple classes #51

Closed
adamjanovsky opened this issue Apr 14, 2021 · 3 comments
Closed

Refactoring: Split large files that cover multiple classes #51

adamjanovsky opened this issue Apr 14, 2021 · 3 comments
Assignees
@adamjanovsky
Labels
refactoring Need to cleanup and refactor

Comments

@adamjanovsky
Copy link
Collaborator

We should probably split gigantic files dataset.py and certificate.py into multiple files, one file per class.
@adamjanovsky adamjanovsky added the refactoring Need to cleanup and refactor label Apr 14, 2021
@adamjanovsky adamjanovsky self-assigned this Apr 14, 2021
@J08nY
Copy link
Member

J08nY commented Apr 16, 2021

Sure, make a dataset or certificate package and create the split files there. Or do it the other way around and have a fips and cc package and have the dataset.py and certificate.py files there.

@adamjanovsky
Copy link
Collaborator Author

Yep, probably dataset and certificate packages, since we're introducing new datasets CVEDataset, CPEDataset, ...

@adamjanovsky
Copy link
Collaborator Author

Closed with #59

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@adamjanovsky adamjanovsky

Labels
refactoring Need to cleanup and refactor
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@J08nY @adamjanovsky