Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test (e2e) : Add test for checking crc status on a stopped crc cluster #4522

Closed
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions test/e2e/features/basic.feature
Original file line number Diff line number Diff line change
Expand Up @@ -61,6 +61,9 @@ Feature: Basic test
Then stdout should match "(.*)[Ss]topped the instance"
And executing "oc whoami" fails
And kubeconfig is cleaned up
# Given CRC Cluster is stopped, When crc status is executed, Then crc should report that cluster is stopped without throwing any error
When executing "crc status"
Then stdout should match "(.*)Stopped"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is basically what next step does "checking that CRC is stopped"

See

test/extended/crc/cmd/cmd.go
138 func CheckCRCStatus(state string) error {

Copy link
Contributor Author

@rohanKanojia rohanKanojia Dec 19, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, you're right.

This scenario was already covered in e2e tests.

# status check
When checking that CRC is stopped
And stdout should not contain "Running"
Expand Down
Loading