test (e2e) : Add test for checking crc status on a stopped crc cluster
#4522
Conversation
Related to crc-org#4512 Add integration test to verify that crc status works after user has run crc stop Signed-off-by: Rohan Kumar <[email protected]>
|
@rohanKanojia: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: anjannath The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
| @@ -61,6 +61,9 @@ Feature: Basic test | |||
| Then stdout should match "(.*)[Ss]topped the instance" | |||
| And executing "oc whoami" fails | |||
| And kubeconfig is cleaned up | |||
| # Given CRC Cluster is stopped, When crc status is executed, Then crc should report that cluster is stopped without throwing any error | |||
| When executing "crc status" | |||
| Then stdout should match "(.*)Stopped" | |||
There was a problem hiding this comment.
This is basically what next step does "checking that CRC is stopped"
See
test/extended/crc/cmd/cmd.go
138 func CheckCRCStatus(state string) error {
There was a problem hiding this comment.
Oh, you're right.
This scenario was already covered in e2e tests.
Description
Related to #4512
While refactoring in #4480, I had mistakenly added this code that was checking for VM IP without checking the status of the VM .
Add integration test to verify that
crc statusworks after user has runcrc stopso that we don't run into this issue again in future.Relates to: #4512, PR #4521
Type of change
test, version modification, documentation, etc.)
Proposed changes
Add e2e test to verify
crc statusworks on a stopped crc clusterTesting
Contribution Checklist