Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: migration for new engineering liberal studies requirement #969

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

feat: migration for new engineering liberal studies requirement #969

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
956fdb9
feat: migration for new engineering liberal studies requirement
import-brain Dec 5, 2024
41819d6
`categories` -> `groups`
import-brain Dec 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
125 changes: 117 additions & 8 deletions src/data/colleges/en.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { Course, CollegeOrMajorRequirement } from '../../requirements/types';
import { Course, CollegeOrMajorRequirement, RequirementMigration } from '../../requirements/types';
import {
courseIsFWS,
includesWithSingleRequirement,
Expand All @@ -10,7 +10,7 @@ import {
import { AdvisorGroup } from '../../tools/advisors/types';
import { lastNameRange, lastNameRanges } from '../../tools/advisors/checkers';

const engineeringLiberalArtsGroups: string[][] = Object.values({
const previousEngineeringLiberalArtsGroups: readonly string[][] = Object.values({
'Group 1': [
'CA-AAP',
'CA-AG',
Expand Down Expand Up @@ -45,6 +45,41 @@ const engineeringLiberalArtsGroups: string[][] = Object.values({
'Group 6': ['CE-EN'],
});

const currentEngineeringLiberalArtsGroups: readonly string[][] = Object.values({
'Group 1': [
'CA-AAP',
'CA-AG',
'CA-AS',
'CA-HE',
'LA-AAP',
'LA-AG',
'LA-AS',
'LAD-HE',
'ALC-AAP',
'ALC-AS',
'ALC-HA',
'SCD-AAP',
'SCD-HA',
],
'Group 2': ['HA-AAP', 'HA-AG', 'HA-AS', 'HA-HE', 'HST-AAP', 'HST-AS', 'HST-HA'],
'Group 3': ['KCM-AAP', 'KCM-AG', 'KCM-AS', 'KCM-HE', 'ETM-AAP', 'ETM-AS', 'ETM-HA'],
'Group 4': [
'SBA-AAP',
'SBA-AG',
'SBA-AS',
'SBA-HE',
'SSC-AAP',
'SSC-AS',
'SSC-HA',
'GLC-AAP',
'GLC-AS',
'GLC-HA',
],
'Group 5': ['FL-AAP', 'FL-AG'],
'Group 6': ['CE-EN'],
'Group 7': ['SCD-AS', 'D-AG'],
});

const engineeringRequirements: readonly CollegeOrMajorRequirement[] = [
{
name: 'Mathematics',
Expand Down Expand Up @@ -129,7 +164,7 @@ const engineeringRequirements: readonly CollegeOrMajorRequirement[] = [
'https://www.engineering.cornell.edu/students/undergraduate-students/advising/liberal-studies',
checker: [
(course: Course): boolean =>
engineeringLiberalArtsGroups.some(group =>
currentEngineeringLiberalArtsGroups.some(group =>
group.some(distribution => hasCategory(course, distribution) ?? false)
) || courseIsForeignLang(course),
],
Expand All @@ -139,19 +174,30 @@ const engineeringRequirements: readonly CollegeOrMajorRequirement[] = [
additionalRequirements: {
'Courses must be from 3 groups.': {
checker: [
...engineeringLiberalArtsGroups.map(group => (course: Course): boolean =>
...currentEngineeringLiberalArtsGroups.map(group => (course: Course): boolean =>
group.some(distribution => hasCategory(course, distribution) ?? false)
),
],
fulfilledBy: 'courses',
perSlotMinCount: [1, 1, 1, 1, 1, 1],
slotNames: ['Group 1', 'Group 2', 'Group 3', 'Group 4', 'Group 5', 'Group 6'],
perSlotMinCount: [1, 1, 1, 1, 1, 1, 1],
slotNames: ['Group 1', 'Group 2', 'Group 3', 'Group 4', 'Group 5', 'Group 6', 'Group 7'],
minNumberOfSlots: 3,
},
'One course of 3 or more credits must come from Group 7.': {
checker: [
(course: Course): boolean =>
currentEngineeringLiberalArtsGroups[
currentEngineeringLiberalArtsGroups.length - 1
].some(distribution => hasCategory(course, distribution) ?? false),
],
Comment on lines +188 to +191
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Destaq How questionable is this?

fulfilledBy: 'courses',
perSlotMinCount: [1],
slotNames: ['Course'],
},
'Courses must have at least 18 credits.': {
checker: [
(course: Course): boolean =>
engineeringLiberalArtsGroups.some(group =>
currentEngineeringLiberalArtsGroups.some(group =>
group.some(distribution => hasCategory(course, distribution) ?? false)
) || courseIsForeignLang(course),
],
Expand All @@ -164,7 +210,7 @@ const engineeringRequirements: readonly CollegeOrMajorRequirement[] = [
const { catalogNbr } = course;
return (
!ifCodeMatch(catalogNbr, '1***') &&
(engineeringLiberalArtsGroups.some(group =>
(currentEngineeringLiberalArtsGroups.some(group =>
group.some(distribution => hasCategory(course, distribution) ?? false)
) ||
courseIsForeignLang(course))
Expand Down Expand Up @@ -276,3 +322,66 @@ export const engineeringAdvisors: AdvisorGroup = {
],
source: 'https://www.engineering.cornell.edu/students/undergraduate-students/advising/meet-staff',
};

export const engMigrations: RequirementMigration[] = [
{
entryYear: 2023,
type: 'Modify',
fieldName: 'Liberal Studies: 6 courses',
newValue: {
name: 'Liberal Studies: 6 courses',
description: 'A minimum of six courses must be taken.',
source:
'https://www.engineering.cornell.edu/students/undergraduate-students/advising/liberal-studies',
checker: [
(course: Course): boolean =>
previousEngineeringLiberalArtsGroups.some(group =>
group.some(distribution => hasCategory(course, distribution) ?? false)
) || courseIsForeignLang(course),
],
fulfilledBy: 'courses',
perSlotMinCount: [6],
slotNames: ['Course'],
additionalRequirements: {
'Courses must be from 3 groups.': {
checker: [
...previousEngineeringLiberalArtsGroups.map(group => (course: Course): boolean =>
group.some(distribution => hasCategory(course, distribution) ?? false)
),
],
fulfilledBy: 'courses',
perSlotMinCount: [1, 1, 1, 1, 1, 1],
slotNames: Object.keys(previousEngineeringLiberalArtsGroups),
minNumberOfSlots: 3,
},
'Courses must have at least 18 credits.': {
checker: [
(course: Course): boolean =>
previousEngineeringLiberalArtsGroups.some(group =>
group.some(distribution => hasCategory(course, distribution) ?? false)
) || courseIsForeignLang(course),
],
fulfilledBy: 'credits',
perSlotMinCount: [18],
},
'Two courses must be at the 2000 level or higher.': {
checker: [
(course: Course): boolean => {
const { catalogNbr } = course;
return (
!ifCodeMatch(catalogNbr, '1***') &&
(previousEngineeringLiberalArtsGroups.some(group =>
group.some(distribution => hasCategory(course, distribution) ?? false)
) ||
courseIsForeignLang(course))
);
},
],
fulfilledBy: 'courses',
perSlotMinCount: [2],
slotNames: ['Course'],
},
},
},
},
];
Loading
Loading