feat: migration for new engineering liberal studies requirement #969
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[diff-counting] Significant lines: 123. |
1 task
|
Visit the preview URL for this PR (updated for commit 41819d6): https://cornelldti-courseplan-dev--pr969-new-eng-lib-studies-pfprpflx.web.app (expires Sun, 05 Jan 2025 14:18:12 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 6d4e0437c4559ed895272bbd63991394f1e0e933 |
import-brain
commented
Dec 6, 2024
Comment on lines
+188
to
+191
| (course: Course): boolean => | ||
| currentEngineeringLiberalArtsGroups[ | ||
| currentEngineeringLiberalArtsGroups.length - 1 | ||
| ].some(distribution => hasCategory(course, distribution) ?? false), |
There was a problem hiding this comment.
@Destaq How questionable is this?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This pull request implements the revamped engineering liberal studies requirement for engineers entering Fall 2024 and later.
https://www.engineering.cornell.edu/students/undergraduate-students/advising/liberal-studies/liberal-studies-requirements-students
Remaining TODOs:
Supersedes #963