go.mod: remove replace inet.af/tcpproxy => github.com/inetaf/tcpproxy
#409
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By copying <https://github.com/inetaf/tcpproxy/blob/91f861402626/tcpproxy.go> to `pkg/tcpproxy/tcpproxy.go`. Signed-off-by: Akihiro Suda <[email protected]>
Signed-off-by: Akihiro Suda <[email protected]>
AkihiroSuda
commented
Oct 17, 2024
| type Matcher func(ctx context.Context, hostname string) bool | ||
|
|
||
| // equals is a trivial Matcher that implements string equality. | ||
| func equals(want string) Matcher { |
There was a problem hiding this comment.
(This unused function had to be removed to silence the linter)
|
Test failure is irrelevant https://github.com/containers/gvisor-tap-vsock/actions/runs/11388213298/job/31684676909?pr=409 |
AkihiroSuda
force-pushed
the
remove-replace-inetaf-tcpproxy
branch
from
cf05e4f to
4589f51
Compare
Signed-off-by: Akihiro Suda <[email protected]>
AkihiroSuda
force-pushed
the
remove-replace-inetaf-tcpproxy
branch
from
4589f51 to
aa45f1b
Compare
cfergeau
approved these changes
Oct 23, 2024
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: AkihiroSuda, cfergeau The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-merge-bot
bot
merged commit 78d4944
into
containers:main
19 of 20 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By copying https://github.com/inetaf/tcpproxy/blob/91f861402626/tcpproxy.go to
pkg/tcpproxy/tcpproxy.go.