Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add more warnings about using the CA issuer safely #1603

Merged
merged 2 commits into from
Dec 2, 2024
Merged

Add more warnings about using the CA issuer safely #1603

merged 2 commits into from
Dec 2, 2024

Conversation

SgtCoDFish
Copy link
Member

No description provided.

@cert-manager-prow cert-manager-prow bot added dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Nov 28, 2024
@netlify Netlify
Copy link

netlify bot commented Nov 28, 2024 •
edited
Loading

✅ Deploy Preview for cert-manager ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 7b2a961
🔍 Latest deploy log https://app.netlify.com/sites/cert-manager/deploys/674d97a5a54a3f0008658245
😎 Deploy Preview https://deploy-preview-1603--cert-manager.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@SgtCoDFish
add mael's suggestions
7b2a961 
Signed-off-by: Ashley Davis <[email protected]>
@SgtCoDFish
Copy link
Member Author

Thanks @maelvls - great suggestions. I've added them now!

@maelvls
Copy link
Member

maelvls commented Dec 2, 2024

Do we need more reviews? Seems like an improvement to me, so I'm happy to approve it... Feel free to unhold if you feel now is the right time to have it merged.

/approve
/lgtm
/hold

@cert-manager-prow cert-manager-prow bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 2, 2024
@cert-manager-prow
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: maelvls

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@cert-manager-prow cert-manager-prow bot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Dec 2, 2024
@SgtCoDFish
Copy link
Member Author

I think it's worth merging this as-is - thanks for the review!

/unhold

@cert-manager-prow cert-manager-prow bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 2, 2024
@SgtCoDFish SgtCoDFish merged commit 9579f14 into cert-manager:master Dec 2, 2024
7 checks passed
@SgtCoDFish SgtCoDFish deleted the ca-issuer-warnings branch December 2, 2024 13:49
@SgtCoDFish SgtCoDFish mentioned this pull request Dec 2, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maelvls maelvls maelvls left review comments

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SgtCoDFish @maelvls