Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some fixes to new language in CA issuer configuration #1605

Merged
merged 1 commit into from
Dec 2, 2024

Conversation

SgtCoDFish
Copy link
Member

Thanks @james-w for the suggestion!

This also makes the whitespace more uniform

@cert-manager-prow cert-manager-prow bot added dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Dec 2, 2024
@SgtCoDFish
Copy link
Member Author

Follow up to #1603

Copy link

netlify bot commented Dec 2, 2024

Deploy Preview for cert-manager ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 58eabe7
🔍 Latest deploy log https://app.netlify.com/sites/cert-manager/deploys/674dc87176aec100081c398b
😎 Deploy Preview https://deploy-preview-1605--cert-manager.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Dec 2, 2024

Deploy Preview for cert-manager ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 2e7b629
🔍 Latest deploy log https://app.netlify.com/sites/cert-manager/deploys/674dc8e5bd1d950008ac7df8
😎 Deploy Preview https://deploy-preview-1605--cert-manager.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@maelvls
Copy link
Member

maelvls commented Dec 2, 2024

/lgtm
/approve

@cert-manager-prow
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: maelvls

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@cert-manager-prow cert-manager-prow bot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Dec 2, 2024
@SgtCoDFish SgtCoDFish merged commit 18cf7a5 into cert-manager:master Dec 2, 2024
7 checks passed
@SgtCoDFish SgtCoDFish deleted the ca-issuer-warnings branch December 2, 2024 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants