Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump cert-manager versions to 1.13 (as described in the release-process) #1295

Merged
merged 4 commits into from
Sep 13, 2023
Merged

Bump cert-manager versions to 1.13 (as described in the release-process) #1295

merged 4 commits into from
Sep 13, 2023

Conversation

inteon
Copy link
Member

@inteon inteon commented Sep 13, 2023 •
edited
Loading

@jetstack-bot jetstack-bot added dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Sep 13, 2023
@inteon
Copy link
Member Author

inteon commented Sep 13, 2023

/hold I'm fixing some search-replace errors, I guess the release-process did not account for them.

@jetstack-bot jetstack-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 13, 2023
@inteon
fix search-replace mistake
85ec920 
Signed-off-by: Tim Ramlot <[email protected]>
SgtCoDFish
SgtCoDFish requested changes Sep 13, 2023
View reviewed changes
Copy link
Member

@SgtCoDFish SgtCoDFish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few bits on this one!

content/docs/installation/supported-releases.md
Comment on lines -21 to -22
| [1.12][] | May 19, 2023 | Release of 1.14 | 1.22 → 1.27 | 4.9 → 4.14 |
| [1.11][] | Jan 11, 2023 | Release of 1.13 | 1.21 → 1.27 | 4.8 → 4.14 |
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggestion: this looks cearly wrong; we're listing 1.13 twice in the new version. I guess the second one should be 1.12. I also don't think that the EoL is "release of 1.14" for 1.12 although I concede the full details of LTS aren't fully fleshed out.

We could say the EOL is "undertermined" add an asterisk saying something like "1.12 will have a longer support timeline than usual; details will follow here before the usual EOL time is reached, which would normally be the release of 1.14".

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added a note, PTAL.

content/v1.13-docs/contributing/README.md Outdated Show resolved Hide resolved
content/v1.13-docs/installation/supported-releases.md Outdated Show resolved Hide resolved
content/v1.13-docs/projects/README.md Outdated Show resolved Hide resolved
@netlify
Copy link

netlify bot commented Sep 13, 2023 •
edited
Loading

✅ Deploy Preview for cert-manager-website ready!

Name Link
🔨 Latest commit ca30521
🔍 Latest deploy log https://app.netlify.com/sites/cert-manager-website/deploys/6501afbd9c73de00082b83a7
😎 Deploy Preview https://deploy-preview-1295--cert-manager-website.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@inteon inteon mentioned this pull request Sep 13, 2023
Merged
SgtCoDFish
SgtCoDFish approved these changes Sep 13, 2023
View reviewed changes
Copy link
Member

@SgtCoDFish SgtCoDFish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

Thanks for doing this, it's not a fun job but someone's gotta do it!

@jetstack-bot jetstack-bot added the lgtm Indicates that a PR is ready to be merged. label Sep 13, 2023
@jetstack-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: SgtCoDFish

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jetstack-bot jetstack-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 13, 2023
@inteon
Copy link
Member Author

inteon commented Sep 13, 2023

/unhold

@jetstack-bot jetstack-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 13, 2023
@jetstack-bot jetstack-bot merged commit 06fe382 into cert-manager:master Sep 13, 2023
1 check passed
@jetstack-bot jetstack-bot mentioned this pull request Dec 7, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SgtCoDFish SgtCoDFish SgtCoDFish approved these changes

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@inteon @jetstack-bot @SgtCoDFish