Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release-process: sed command not compatible with BSD sed and other improvements #1276

Merged
merged 12 commits into from
Oct 16, 2023
Merged

Release-process: sed command not compatible with BSD sed and other improvements #1276

merged 12 commits into from
Oct 16, 2023

Conversation

maelvls
Copy link
Member

@maelvls maelvls commented Sep 1, 2023 •
edited
Loading

I found a few issues when releasing 1.11.5 and 1.12.4. A lot of the commands I had added when releasing 1.12.0 two months ago were broken or untested. 😅

xref: #1277

@jetstack-bot jetstack-bot added dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 1, 2023
@netlify
Copy link

netlify bot commented Sep 1, 2023 •
edited
Loading

✅ Deploy Preview for cert-manager-website ready!

Name Link
🔨 Latest commit 3acae8a
🔍 Latest deploy log https://app.netlify.com/sites/cert-manager-website/deploys/650446cf16ac9d0008672fd2
😎 Deploy Preview https://deploy-preview-1276--cert-manager-website.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@maelvls maelvls force-pushed the update-release-process branch from 8e1c0e5 to e6a60e0 Compare September 1, 2023 15:01
@jetstack-bot jetstack-bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 1, 2023
@maelvls maelvls force-pushed the update-release-process branch 2 times, most recently from 47f5460 to b4ac615 Compare September 1, 2023 16:59
@maelvls
Copy link
Member Author

maelvls commented Sep 1, 2023

Oh no... I somehow reformatted the whole file...

/hold

@jetstack-bot jetstack-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 1, 2023
@maelvls
release-process: sed command not compatible with BSD sed
123141f 
Signed-off-by: Maël Valais <[email protected]>
@maelvls
release-process: fix find command being too loose
f6d5d41 
Signed-off-by: Maël Valais <[email protected]>
@maelvls
release-process: jetstack -> cert-manager
7eb34ca 
Signed-off-by: Maël Valais <[email protected]>
@maelvls
release-process: the update-cmd/ctl/ thing only works for 1.12 and above
876e037 
Signed-off-by: Maël Valais <[email protected]>
@maelvls
release-process: reformulate 1.10-specific parts
17763b1 
Signed-off-by: Maël Valais <[email protected]>
@maelvls
release-process: fix release-notes already-ready URLs
fa52c9e 
Signed-off-by: Maël Valais <[email protected]>
@maelvls
release-process: explain that you need to push the branch
d2569b7 
Signed-off-by: Maël Valais <[email protected]>
@maelvls
release-process: fixes
42faf39 
Signed-off-by: Maël Valais <[email protected]>
@maelvls maelvls force-pushed the update-release-process branch from b4ac615 to 42faf39 Compare September 1, 2023 17:58
@jetstack-bot jetstack-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Sep 1, 2023
@maelvls maelvls changed the title Release-process: sed command not compatible with BSD sed Release-process: sed command not compatible with BSD sed and other improvements Sep 1, 2023
@maelvls maelvls removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 1, 2023
@maelvls
release-process: fix spelling
394bbbe 
Signed-off-by: Maël Valais <[email protected]>
@maelvls
Copy link
Member Author

maelvls commented Sep 5, 2023

I un-formated the file.

/unhold

@maelvls maelvls requested a review from inteon September 5, 2023 18:13
@maelvls
release-process: -E should come before -e
670e8b7 
Otherwise, -E doens't apply to the sed commands

Signed-off-by: Maël Valais <[email protected]>
@maelvls
Copy link
Member Author

maelvls commented Sep 13, 2023

Please take another look @inteon.

@inteon
Copy link
Member

inteon commented Sep 13, 2023

Another important note:
when we freeze the docs for a certain version, there are a few additional sections that we should remove:

inteon
inteon approved these changes Sep 15, 2023
View reviewed changes
Copy link
Member

@inteon inteon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/hold in case you still want to change something

@jetstack-bot jetstack-bot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm Indicates that a PR is ready to be merged. labels Sep 15, 2023
@jetstack-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: inteon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jetstack-bot jetstack-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 15, 2023
@inteon
Copy link
Member

inteon commented Oct 16, 2023

/unhold

@jetstack-bot jetstack-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 16, 2023
@jetstack-bot jetstack-bot merged commit d9ca1b9 into cert-manager:master Oct 16, 2023
1 check passed
@jetstack-bot jetstack-bot mentioned this pull request Dec 7, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@inteon inteon inteon approved these changes

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@maelvls @inteon @jetstack-bot