-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rotation api extension #15169
Rotation api extension #15169
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! I think this is a useful API. Left some non-blocking suggestions
CC @johannesvollmer; this doesn't fully address what you described in #11132 (comment), because |
Co-authored-by: Joona Aalto <[email protected]>
53e8df5
to
3b73b1b
Compare
Yes, still useful :) nice |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! Left some minor documentation improvements :)
IMO the "resulting rotation" in the docs would be clearer as the "input rotation", since otherwise it reads as if the resulting rotation was once in radians, once in degrees, and once in fractions, which is not the case. But I'll leave that up to you.
Co-authored-by: Jan Hohenheim <[email protected]>
717baf1
to
9ce869b
Compare
Objective
Angle
type #11132 (comment)Solution
Rot2
turn_fraction(fraction: f32) -> Self
as_turn_fraction(self) -> f32
Testing
Showcase