-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve and fix libs-credentials #569
Conversation
…ttestations structure BREAKING CHANGES: EASContext type now take in network and address instead of queryGraph.
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
…ntials to README" This reverts commit fb64931.
Thank you very much for the updates @waddaboo. I left some comments. |
Thanks for the review and catching the parts that I missed. I have updated the code based on your comments and is now ready for review again :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks great! Just left one comment. I think the PR is ready to be merged after the comment is resolved. Thank you very much.
Co-authored-by: Vivian Plasencia <[email protected]>
Done :) |
Thanks @waddaboo! Could you also update the readme file for the EAS credential? |
I do have another PR #572 that updates the readme file, or did I miss out something? |
Great! I didn't see that you also updated that PR. It looks great! I will merge both PRs and release a new version of the packages. Thank you very much @waddaboo Feel free to update the API and Dashboard with the new changes. |
Description
This PR fixes a bug where the
queryGraph
function does not return therequest
function as intended.This PR also has a code refactor that introduces a breaking change at validate
easAttestation
.Specifically, validate
easAttestation
context no longer takes inqueryGraph
butnetwork
andaddress
instead.Example (Old):
Example (New):
Related Issue
#568
Does this introduce a breaking change?
Please refer to the examples given above to migrate from the old easAttestation context to the new easAttestation context.