Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add EAS Attestation credentials to API and Dashboard #574

Merged
merged 14 commits into from
Oct 11, 2024

Conversation

waddaboo
Copy link
Collaborator

@waddaboo waddaboo commented Oct 10, 2024

Description

This PR implements a new feature to the the credentials API for easAttestations, introduced by PR #569.
This PR also implements the said API for Dashboard.

The URL structure to join a group is:

http://localhost:3001/credentials?group=<group-id>&member=<member-commitment>&provider=eas&redirect_uri=<redirect-url>

Related Issue

Closes #573

Does this introduce a breaking change?

  • Yes
  • No

@waddaboo waddaboo requested a review from vplasencia October 10, 2024 07:50
Copy link

vercel bot commented Oct 10, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
bandada-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 11, 2024 7:15am
bandada-website ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 11, 2024 7:15am

@waddaboo waddaboo changed the base branch from main to dev October 10, 2024 10:55
Copy link
Member

@vplasencia vplasencia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks great! Thanks.

Could you add to the PR description that the structure of the URL to join a group is:

http://localhost:3001/credentials?group=<group-id>&member=<member-commitment>&provider=eas&redirect_uri=<redirect-url>

@waddaboo
Copy link
Collaborator Author

Done!

@vplasencia vplasencia merged commit d525575 into dev Oct 11, 2024
5 checks passed
@waddaboo waddaboo deleted the feat/dashboard-credentials branch October 11, 2024 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add EAS Attestations to API and Dashboard
2 participants