-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(dashboard): resolve issue preventing dashboard app from loading #514
Conversation
fix: resolve rebase conflicts fix: resolve rebase conflicts fix: resolve rebase conflicts fix: resolve rebase conficts fix: resolve rebase conflicts
fix: resolve rebase conflicts fix: resolve rebase conflicts
Co-authored-by: Vivian Plasencia <[email protected]>
Co-authored-by: Vivian Plasencia <[email protected]>
Upgrade `ethers` and related dependencies to latest version
Add search bar to Bandada docs bandada-infra#476
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Hey @baumstern thank you very much for creating this PR. Is Bandada working fine for you in dev environment? I just tested it and I see some errors in the browser console. I think this could help: |
I bumped Just in case, you might need to provide the VITE_PROJECT_ID environment variable to prevent an issue related to wallet connect like following console errors: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lovely - tysm!
update: bumped the version of Also, currently we are troubleshooting the issue that this PR introduced with @vplasencia. Signed-in status doesn't persist from her side. But I failed to reproduce it. |
thx for the updates - keep us posted. |
Hey @baumstern! I will close this PR because there is a new branch that will serve as a reference for future updates of the ethers dependency. Please see https://github.com/bandada-infra/bandada/tree/chore/update-ethers There is also a new issue focused on improving the wallet UX, please see: #550 Thank you very much for the work 🙏 |
Description
In the production build, there's an issue preventing the Dashboard app from loading in the browser. The following errors are logged:
The issue has been traced to UI.generateApi(), which is part of the siwe package. The siwe package was updated from version
^1.1.6
to^2.1.4
in commit 871f01a. Bumpingsiwe
to version^2.3.2
resolves the current issue.Related Issue
Does this introduce a breaking change?
Other information