-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Many-to-Many relationship between Group and Member #325
Add Many-to-Many relationship between Group and Member #325
Conversation
BREAKING CHANGE: Many-to-many relationship between Group and Member fix #265
#305 could be potentially related to this. Need further check |
Are we sure we want to maintain this |
Hey! What do you mean? It is better to fix all the errors. |
nvm, everything should be okay with the last commit. Used a |
@vplasencia Ready for review :) |
Congrats, your important contribution to this open-source project has earned you a GitPOAP! Head to gitpoap.io & connect your GitHub account to mint! Learn more about GitPOAPs here. |
Description
This PR introduces a Many-to-Many relationship between Group and Member (a Group can contain multiple Members and a Member can join one or more Groups). The relationship is unidirectional and maintained in the Group. This allows for a join table between Group and Member that does not affect the current APIs, introducing an externally imperceptible (non-breaking) change. This approach was chosen because the join table did not require additional information beyond the Group and Member identifiers having a relationship, denoted by the term
Membership
.Related Issue
Does this introduce a breaking change?