Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Many-to-Many relationship between Group and Member #325

Merged
merged 2 commits into from
Nov 9, 2023

Conversation

0xjei
Copy link
Collaborator

@0xjei 0xjei commented Oct 27, 2023

Description

This PR introduces a Many-to-Many relationship between Group and Member (a Group can contain multiple Members and a Member can join one or more Groups). The relationship is unidirectional and maintained in the Group. This allows for a join table between Group and Member that does not affect the current APIs, introducing an externally imperceptible (non-breaking) change. This approach was chosen because the join table did not require additional information beyond the Group and Member identifiers having a relationship, denoted by the term Membership.

Related Issue

Does this introduce a breaking change?

  • Yes
  • No

BREAKING CHANGE: Many-to-many relationship between Group and Member

fix #265
@0xjei 0xjei added the refactoring ♻️ A code change that neither fixes a bug nor adds a feature label Oct 27, 2023
@0xjei 0xjei requested a review from vplasencia October 27, 2023 18:56
@0xjei 0xjei self-assigned this Oct 27, 2023
@0xjei 0xjei changed the base branch from main to dev October 27, 2023 18:56
@0xjei
Copy link
Collaborator Author

0xjei commented Oct 30, 2023

#305 could be potentially related to this. Need further check

@0xjei
Copy link
Collaborator Author

0xjei commented Oct 30, 2023

Are we sure we want to maintain this Unexpected await inside a loop no-await-in-loop lint error? @vplasencia

@vplasencia
Copy link
Member

Are we sure we want to maintain this Unexpected await inside a loop no-await-in-loop lint error? @vplasencia

Hey! What do you mean? It is better to fix all the errors.

@0xjei
Copy link
Collaborator Author

0xjei commented Oct 31, 2023

Are we sure we want to maintain this Unexpected await inside a loop no-await-in-loop lint error? @vplasencia

Hey! What do you mean? It is better to fix all the errors.

Are we sure we want to maintain this Unexpected await inside a loop no-await-in-loop lint error? @vplasencia

Hey! What do you mean? It is better to fix all the errors.

nvm, everything should be okay with the last commit. Used a map with Promise.all() instead of a for loop.

@0xjei
Copy link
Collaborator Author

0xjei commented Oct 31, 2023

Are we sure we want to maintain this Unexpected await inside a loop no-await-in-loop lint error? @vplasencia

Hey! What do you mean? It is better to fix all the errors.

Are we sure we want to maintain this Unexpected await inside a loop no-await-in-loop lint error? @vplasencia

Hey! What do you mean? It is better to fix all the errors.

nvm, everything should be okay with the last commit. Used a map with Promise.all() instead of a for loop.

@vplasencia Ready for review :)

@vplasencia vplasencia changed the base branch from dev to feat/many-to-many-group-member November 9, 2023 10:56
@vplasencia vplasencia merged commit 0343163 into feat/many-to-many-group-member Nov 9, 2023
2 checks passed
Copy link

gitpoap-bot bot commented Nov 9, 2023

Congrats, your important contribution to this open-source project has earned you a GitPOAP!

2023 Bandada Contributor:

2023 Bandada Contributor GitPOAP Badge

Head to gitpoap.io & connect your GitHub account to mint!

Learn more about GitPOAPs here.

@vplasencia vplasencia deleted the refactoring/entities branch November 10, 2023 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactoring ♻️ A code change that neither fixes a bug nor adds a feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The same member ID cannot be used in more than 1 group
2 participants