Move API key logic from GroupsService to AdminsService
#446
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
This was referenced Mar 22, 2024
vplasencia
approved these changes
Mar 28, 2024
This was
linked to
issues
Mar 28, 2024
…ssage verification in UI
vplasencia
approved these changes
Mar 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR aims to add functionality for creating, updating, and deleting groups using API keys. The business logic for API keys has been updated to allow for one API key per admin instead of one API key per group. This means that each admin can manage all of their groups with the same API key. Further improvements will be released to support multiple API keys per admin.
In this setting, where there is one key and one admin, we can manage the logic in the admin instead of creating new relations or tables in the database.
This works for any kind of off-chain groups (manual & credential).
The last commit adds the following missing APIs and necessary refactoring to make APISdk and dashboard work
Related Issue
re #318
closes #225
closes #245
closes #448
closes #457
Does this introduce a breaking change?
This change modifies the underlying logic of API keys from 'Group' to 'Admin', restricting to one API key per 'Admin' instead of per 'Group'. Then, it can be considered a breaking change.
Other information
The most important feature is that an administrator can create, remove and update one or more groups by using his or her own API key.
In addition to the breaking change in the underlying logic, the following minor improvements and fixes have been made:
@types/uuidAdminServicetoAdminsServiceto follow the other services conventionAdminControllerAdminsServicetestsGroupsService