Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing issue 1262: AWSTraceHeader is now propagated #1287

Merged
merged 1 commit into from
Dec 11, 2024
Merged

Fixing issue 1262: AWSTraceHeader is now propagated #1287

merged 1 commit into from
Dec 11, 2024

Conversation

acomofcg
Copy link
Contributor

@acomofcg acomofcg commented Nov 29, 2024 •
edited
Loading

📢 Type of change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring

📜 Description

The fix propagates correctly the tracing header (AWSTraceHeader) as SQS message system attribute, when available among Spring Message headers

💡 Motivation and Context

This PR is for fixing #1262

💚 How did you test it?

Added two tests: on SqsTemplateTests and SqsHeaderMapperTests involving the methods that have been changed

📝 Checklist

  • I reviewed submitted code
  • I added tests to verify changes
  • I updated reference documentation to reflect the change
  • All tests passing
  • No breaking changes

🔮 Next steps

@github-actions github-actions bot added the component: sqs SQS integration related issue label Nov 29, 2024
@acomofcg acomofcg mentioned this pull request Nov 29, 2024
Closed
MatejNedic
MatejNedic approved these changes Dec 8, 2024
View reviewed changes
Copy link
Member

@MatejNedic MatejNedic left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. @tomazfernandes what do you think?

Only worried .name() to toString() could be breaking change

@acomofcg
Copy link
Contributor Author

acomofcg commented Dec 11, 2024 •
edited
Loading

Looks good to me. @tomazfernandes what do you think?

Only worried .name() to toString() could be breaking change

Hi @MatejNedic, thanks for your approval
That change is actually the fix to the problem related to the issue #1262

@maciejwalkowiak maciejwalkowiak added this to the 3.3.0 M2 milestone Dec 11, 2024
@maciejwalkowiak maciejwalkowiak merged commit a9f51fc into awspring:main Dec 11, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MatejNedic MatejNedic MatejNedic approved these changes

@maciejwalkowiak maciejwalkowiak Awaiting requested review from maciejwalkowiak maciejwalkowiak is a code owner

@tomazfernandes tomazfernandes Awaiting requested review from tomazfernandes tomazfernandes is a code owner

Assignees
No one assigned
Labels
component: sqs SQS integration related issue
Projects
None yet
Milestone
3.3.0 RC1
Development

Successfully merging this pull request may close these issues.
3 participants
@acomofcg @MatejNedic @maciejwalkowiak