Can't add AWSTraceHeader as system attribute because is replaced with "null"

[acomofcg]

Type: Bug

Component:
"SQS"

Describe the bug
In Spring Cloud 3.1.1 I can't send the MessageSystemAttribute AWSTraceHeader: when setting the attribute, in the system attribute map of software.amazon.awssdk.services.sqs.model.Message object, the key is replaced with "null" string when converted to SendMessageRequest, and SQS return 400.

Debugging the code, I found that the problem is the SqsTemplate class when converting MessageSystemAttributeName into MessageSystemAttributeNameForSends, method mapMessageSystemAttributes at line 457.

Possible fixes:

replace

MessageSystemAttributeNameForSends.fromValue(entry.getKey().name())

with

MessageSystemAttributeNameForSends.fromValue(entry.getKey().toString())

or

MessageSystemAttributeNameForSends.valueOf(entry.getKey().name())

What happening now is that the system attribute sent is

"null" -> "Root=1-c29f4bf9-2c45b3e36f5984be173ddfaf;Parent=5b48b4b16bff358a;Sampled=1"

instead of

"AWSTraceHeader" -> "Root=1-c29f4bf9-2c45b3e36f5984be173ddfaf;Parent=5b48b4b16bff358a;Sampled=1"

which is rejected by AWS.

[maciejwalkowiak]

@tomazfernandes could you take a look?

[acomofcg]

Hi @maciejwalkowiak @tomazfernandes any news on this?

[maciejwalkowiak]

@acomofcg not yet. If you would like to contribute fix, PRs welcome!

[tomazfernandes]

@acomofcg, thanks for bringing this up.

I wonder why this fails for this particular attribute and not the other ones?

Thanks

[acomofcg]

Hi @tomazfernandes,

as far as I understand, the tracing header is the only attribute allowed to be used among system attributes, which is not mixed with the "normal" message attributes. This is why MessageSystemAttributeNameForSends has only one allowed value I guess.

Thanks for your help.

[acomofcg]

Hi @tomazfernandes @maciejwalkowiak I opened a PR (#1287) for fixing the problem.

Please let me know if the tests are enough

Thanks