code-refactoring: implement repo-server

coding-standards-and-best-practices.md

@@ -214,18 +214,18 @@ if rr.Instance.Spec.HA.Enabled {
 acr.Logger.Error(err, "reconcileManagedRoles: failed to retrieve role", "name", existingRole.Name, "namespace", existingRole.Namespace)
 ```
 
-- Use debug level (`Logger.V(1).Info`) when recording non-essential information. i.e, information on events that don't block happy path execution, but can provide hints if troubleshooting is needed e.g:
+- Use debug level (`Logger.Debug`) when recording non-essential information. i.e, information on events that don't block happy path execution, but can provide hints if troubleshooting is needed e.g:
 
 ```
-acr.Logger.V(1).Info("reconcileManagedRoles: one or more mutations could not be applied")
-acr.Logger.V(1).Info("reconcileManagedRoles: skip reconciliation in favor of custom role", "name", customRoleName)
+acr.Logger.Debug("reconcileManagedRoles: one or more mutations could not be applied")
+acr.Logger.Debug("reconcileManagedRoles: skip reconciliation in favor of custom role", "name", customRoleName)
 ```
 
-- Use Info level (`Logger.Info` or `Logger.V(0).Info`) for all other info-level logs.  Any new action taken by the controller that is critical to normal functioning.
+- Use Info level (`Logger.Info`) for all other info-level logs.  Any new action taken by the controller that is critical to normal functioning.
 - - No need to mention function names when logging at `info` level. eg:
 
 ```
-acr.Logger.V(0).Info("role created", "name", desiredRole.Name, "namespace", desiredRole.Namespace)
+acr.Logger.Info("role created", "name", desiredRole.Name, "namespace", desiredRole.Namespace)
 ```
 
 - Only use log statements to log success/error if the function belongs to a controller package and is invoked by the controller. No need to log statements from utility/helper packages. e.g:

common/TOBEREMOVED.go

@@ -160,6 +160,15 @@ const (
 	// ArgoCDRedisHAImageEnvVar is the environment variable used to get the image
 	// to used for the the Redis container in HA mode.
 	ArgoCDRedisHAImageEnvVar = "ARGOCD_REDIS_HA_IMAGE"
+
+	// ArgoCDDefaultRepoMetricsPort is the default listen port for the Argo CD repo server metrics.
+	ArgoCDDefaultRepoMetricsPort = 8084
+
+	// ArgoCDDefaultRepoServerPort is the default listen port for the Argo CD repo server.
+	ArgoCDDefaultRepoServerPort = 8081
+
+	// ArgoCDKeyRelease is the prometheus release key for labels.
+	ArgoCDKeyRelease = "release"
 )
 
 // DefaultLabels returns the default set of labels for controllers.

common/envVars.go

@@ -14,10 +14,6 @@ const (
 	// to used for the Keycloak container.
 	ArgoCDKeycloakImageEnvVar = "ARGOCD_KEYCLOAK_IMAGE"
 
-	// ArgoCDRepoImageEnvVar is the environment variable used to get the image
-	// to used for the Dex container.
-	ArgoCDRepoImageEnvVar = "ARGOCD_REPOSERVER_IMAGE"
-
 	// ArgoCDGrafanaImageEnvVar is the environment variable used to get the image
 	// to used for the Grafana container.
 	ArgoCDGrafanaImageEnvVar = "ARGOCD_GRAFANA_IMAGE"
@@ -34,4 +30,6 @@ const (
 
 	// ArgoCDLabelSelectorEnvVar is an environment variable that contains the labels used for selective instance reconilliation.
 	ArgoCDLabelSelectorEnvVar = "ARGOCD_LABEL_SELECTOR"
+
+	ArgoCDExecTimeoutEnvVar = "ARGOCD_EXEC_TIMEOUT"
 )

common/keys.go

@@ -78,9 +78,6 @@ const (
 	// ArgoCDKeyRBACScopes is the configuration key for the Argo CD RBAC scopes.
 	ArgoCDKeyRBACScopes = "scopes"
 
-	// ArgoCDKeyRelease is the prometheus release key for labels.
-	ArgoCDKeyRelease = "release"
-
 	// ArgoCDKeyResourceExclusions is the configuration key for resource exclusions.
 	ArgoCDKeyResourceExclusions = "resource.exclusions"
 

common/names.go

@@ -34,4 +34,6 @@ const (
 const (
 	// ArgoCDCASuffix is the name suffix for ArgoCD CA resources.
 	ArgoCDCASuffix = "ca"
+
+	MetricsSuffix = "metrics"
 )

common/notifications.go

@@ -2,6 +2,7 @@ package common
 
 // notifications
 const (
+	NotificationsController          = "notifications-controller"
 	NotificationsControllerComponent = "argocd-notifications-controller"
 	NotificationsSecretName          = "argocd-notifications-secret"
 	NotificationsConfigMapName       = "argocd-notifications-cm"

common/prometheus.go

@@ -4,6 +4,9 @@ package common
 const (
 	// ArgoCDKeyPrometheus is the resource prometheus key for labels.
 	ArgoCDKeyPrometheus = "prometheus"
+
+	// PrometheusReleaseKey is the prometheus release key for labels.
+	PrometheusReleaseKey = "release"
 )
 
 // defaults

common/redis.go

@@ -89,3 +89,11 @@ const (
 const (
 	RedisTLSCertChangedKey = "redis.tls.cert.changed"
 )
+
+// commands
+const (
+	RedisCmd                      = "--redis"
+	RedisUseTLSCmd                = "--redis-use-tls"
+	RedisInsecureSkipTLSVerifyCmd = "--redis-insecure-skip-tls-verify"
+	RedisCACertificate            = "--redis-ca-certificate"
+)

common/reposerver.go

@@ -2,10 +2,20 @@ package common
 
 // names
 const (
+	RepoServerController = "repo-server-controller"
+
+	// RepoServerComponent is the repo-server control plane component
+	RepoServerComponent = "repo-server"
+
+	ArgoCDRepoServerName = "argocd-repo-server"
+
 	// ArgoCDRepoServerTLSSecretName is the name of the TLS secret for the repo-server
 	ArgoCDRepoServerTLSSecretName = "argocd-repo-server-tls"
+)
 
-	RepoServerSuffix = "-repo-server"
+// suffixes
+const (
+	RepoServerSuffix = "repo-server"
 )
 
 // values
@@ -16,9 +26,26 @@ const (
 
 // defaults
 const (
-	// ArgoCDDefaultRepoMetricsPort is the default listen port for the Argo CD repo server metrics.
-	ArgoCDDefaultRepoMetricsPort = 8084
+	// DefaultRepoServerMetricsPort is the default listen port for the Argo CD repo server metrics.
+	DefaultRepoServerMetricsPort = 8084
+
+	// DefaultRepoServerPort is the default listen port for the Argo CD repo server.
+	DefaultRepoServerPort = 8081
+)
+
+// env vars
+const (
+	// ArgoCDRepoImageEnvVar is the environment variable used to get the image to be used for
+	// the repo-server container
+	ArgoCDRepoImageEnvVar = "ARGOCD_REPOSERVER_IMAGE"
+)
 
-	// ArgoCDDefaultRepoServerPort is the default listen port for the Argo CD repo server.
-	ArgoCDDefaultRepoServerPort = 8081
+// keys
+const (
+	RepoTLSCertChangedKey = "repo.tls.cert.changed"
+)
+
+// commands
+const (
+	RepoServerCmd = "argocd-repo-server"
 )

common/values.go

@@ -49,6 +49,8 @@ const (
 	ArgoCDStatusRunning = "Running"
 
 	ArgoCDStatusAvailable = "Available"
+
+	PrometheusOperator = "prometheus-operator"
 )
 
 // general values
@@ -88,5 +90,7 @@ const (
 
 // Commnds
 const (
-	LogLevel = "--loglevel"
+	LogLevelCmd     = "--loglevel"
+	LogFormatCmd    = "--logformat"
+	UidEntryPointSh = "uid_entrypoint.sh"
 )