code-refactoring: implement repo-server #1016

ciiay · 2023-10-06T15:57:44Z

What type of PR is this?
/kind code-refactoring

What does this PR do / why we need it:
This PR implements the repo-server controller and adds unit tests where possible.
This PR does not include end-to-end tests since there is a dependency on other controllers for that

Have you updated the necessary documentation?

Documentation update is required by this PR.
Documentation has been updated.
Which issue(s) this PR fixes:

Fixes #?
GITOPS-3125: https://issues.redhat.com/browse/GITOPS-3125

How to test changes / Special notes to the reviewer:

run Argo CD operator
apply the following CR:

apiVersion: argoproj.io/v1beta1
kind: ArgoCD
metadata:
  name: project-gitops
spec:
  repo:
    enabled: true

confirm that repo-server resources come up, and repo-server deployment is running
disable repo-server as follows

apiVersion: argoproj.io/v1beta1
kind: ArgoCD
metadata:
  name: project-gitops
spec:
  repo:
    enabled: false

confirm that repo-server resources are deleted

…j-labs#918) * upgrade golangci-lint Signed-off-by: Jaideep Rao <[email protected]> * fix phase reconciliation during host reconciliation Signed-off-by: Jaideep Rao <[email protected]> * address review comment Signed-off-by: Jaideep Rao <[email protected]> * set phase to pending if ingress not found Signed-off-by: Jaideep Rao <[email protected]> --------- Signed-off-by: Jaideep Rao <[email protected]>

* Move to only adding two roles for managed namespaces --------- Signed-off-by: Salem Elrahal <[email protected]> Co-authored-by: Salem Elrahal <[email protected]>

Track and expose custom operator performance metrics --------- Signed-off-by: Jaideep Rao <[email protected]>

…argoproj-labs#964) * Add ArgoCD v1beta1 & deprecate v1alpha1 - Add new ArgoCD v1beta1 api - Mark ArgoCD v1alpha1 as deprecated & add back the removed sso fields - Use server side validation for "kubectl apply" as client side results into failure due to exceeding annotation size limit. Signed-off-by: Siddhesh Ghadi <[email protected]> Add funcs for ArgoCD alpha to beta conversion Signed-off-by: Siddhesh Ghadi <[email protected]> Add conversion webhook - Create webhook & setup webhook server on 9443 - Disable operator namespaced install via OLM so that OLM can handle certs for webhook server - For manual install, user needs to explicitly configure cert manager to inject certs and enable webhook server in operator by setting env ENABLE_CONVERSION_WEBHOOK="true" Signed-off-by: Siddhesh Ghadi <[email protected]> Resolve local build issues Signed-off-by: Siddhesh Ghadi <[email protected]> Tweak webhook configs Signed-off-by: Siddhesh Ghadi <[email protected]> Update operator installation docs Signed-off-by: Siddhesh Ghadi <[email protected]> Add e2e tests Signed-off-by: Siddhesh Ghadi <[email protected]> Minor updates Signed-off-by: Siddhesh Ghadi <[email protected]> Fix go-lint ci failure Signed-off-by: Siddhesh Ghadi <[email protected]> Update docs Signed-off-by: Siddhesh Ghadi <[email protected]> Remove webhook from 0.7.0 bundle Signed-off-by: Siddhesh Ghadi <[email protected]> Add spaces in bundle Signed-off-by: Siddhesh Ghadi <[email protected]> * update 0.8.0 bundle Signed-off-by: Siddhesh Ghadi <[email protected]> --------- Signed-off-by: Siddhesh Ghadi <[email protected]>

…bs#950) Bumps [pygments](https://github.com/pygments/pygments) from 2.7.4 to 2.15.0. - [Release notes](https://github.com/pygments/pygments/releases) - [Changelog](https://github.com/pygments/pygments/blob/master/CHANGES) - [Commits](pygments/pygments@2.7.4...2.15.0) --- updated-dependencies: - dependency-name: pygments dependency-type: direct:production ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* upgrade RH-SSO from 7.5 to 7.6 Signed-off-by: iam-veeramalla <[email protected]> * fix: failing tests Signed-off-by: iam-veeramalla <[email protected]> * fix: failing tests Signed-off-by: iam-veeramalla <[email protected]> --------- Signed-off-by: iam-veeramalla <[email protected]>

* Remove dead code Signed-off-by: Siddhesh Ghadi <[email protected]> * Fix import Signed-off-by: Siddhesh Ghadi <[email protected]> * Fix imports Signed-off-by: Siddhesh Ghadi <[email protected]> --------- Signed-off-by: Siddhesh Ghadi <[email protected]>

Signed-off-by: Siddhesh Ghadi <[email protected]>

…bs#973) * Remove .spec.resourceCustomizations code Signed-off-by: Siddhesh Ghadi <[email protected]> * Update docs Signed-off-by: Siddhesh Ghadi <[email protected]> * Update docs Signed-off-by: Siddhesh Ghadi <[email protected]> * Address review comments Signed-off-by: Siddhesh Ghadi <[email protected]> * Fix typo Signed-off-by: Siddhesh Ghadi <[email protected]> --------- Signed-off-by: Siddhesh Ghadi <[email protected]>

* upgrade ArgoCD version to 2.8.2 and update the CRDs Signed-off-by: ishitasequeira <[email protected]> * Update argocd image Signed-off-by: ishitasequeira <[email protected]> --------- Signed-off-by: ishitasequeira <[email protected]>

* Update ArgoCD v1alpha1 deprecation message Signed-off-by: Siddhesh Ghadi <[email protected]> * Run code gen Signed-off-by: Siddhesh Ghadi <[email protected]> --------- Signed-off-by: Siddhesh Ghadi <[email protected]>

…rgoproj-labs#985) * add support for tls self signed certs in AppSet Gitlab SCM Provider Signed-off-by: ishitasequeira <[email protected]> * add e2e test Signed-off-by: ishitasequeira <[email protected]> * add unit tests Signed-off-by: ishitasequeira <[email protected]> * renamed field ScmRootCaPath to SCMRootCaPath Signed-off-by: ishitasequeira <[email protected]> * Add documentation and address comments Signed-off-by: ishitasequeira <[email protected]> * Address comments Signed-off-by: ishitasequeira <[email protected]> --------- Signed-off-by: ishitasequeira <[email protected]>

…rgoproj-labs#992) Bumps [github.com/argoproj/argo-cd/v2](https://github.com/argoproj/argo-cd) from 2.8.2 to 2.8.3. - [Release notes](https://github.com/argoproj/argo-cd/releases) - [Changelog](https://github.com/argoproj/argo-cd/blob/master/CHANGELOG.md) - [Commits](argoproj/argo-cd@v2.8.2...v2.8.3) --- updated-dependencies: - dependency-name: github.com/argoproj/argo-cd/v2 dependency-type: direct:production ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Signed-off-by: iam-veeramalla <[email protected]>

) Signed-off-by: minchao <[email protected]>

…operator docs (argoproj-labs#1002) * Update requirements.txt added markdown= 3.3.7 and markdown-include=0.6.0 Signed-off-by: Surajyadav <[email protected]> * Delete docs/assets/extra.css deleted extra.css Signed-off-by: Surajyadav <[email protected]> * Update mkdocs.yml added markdown_extension markdown_include with codehighlight and toggle for screen mode Signed-off-by: Surajyadav <[email protected]> * Update mkdocs.yml Signed-off-by: Surajyadav <[email protected]> --------- Signed-off-by: Surajyadav <[email protected]>

…goproj-labs#1007) * fix: keycloak probes failure results in pod crash Signed-off-by: iam-veeramalla <[email protected]> * fix: use latest keycloak image to handle performance issue Signed-off-by: iam-veeramalla <[email protected]> --------- Signed-off-by: iam-veeramalla <[email protected]>

Signed-off-by: Yi Cai <[email protected]>

…goproj-labs#1013) * account for empty group during resource customization config subkey generation --------- Signed-off-by: Jaideep Rao <[email protected]>

Signed-off-by: Yi Cai <[email protected]>

…-3125-implement-repo-server

Signed-off-by: Yi Cai <[email protected]>

…gocd-operator into operator-redesign-repo-server

Signed-off-by: Jaideep Rao <[email protected]>

…gocd-operator into operator-redesign-repo-server

Signed-off-by: Jaideep Rao <[email protected]>

…argocd-operator into operator-redesign-repo-server

Signed-off-by: Jaideep Rao <[email protected]>

…argocd-operator into operator-redesign-repo-server

Signed-off-by: Jaideep Rao <[email protected]>

…at end of cycle Signed-off-by: Jaideep Rao <[email protected]>

Signed-off-by: Jaideep Rao <[email protected]>

jaideepr97 and others added 29 commits July 20, 2023 17:55

update owners file (argoproj-labs#953)

4d09aca

Move to only adding two roles for managed namespaces (argoproj-labs#954)

45f3597

* Move to only adding two roles for managed namespaces --------- Signed-off-by: Salem Elrahal <[email protected]> Co-authored-by: Salem Elrahal <[email protected]>

feat: expose operator metrics (argoproj-labs#928)

c7cfa8c

Track and expose custom operator performance metrics --------- Signed-off-by: Jaideep Rao <[email protected]>

add build.os config for readthedocs (argoproj-labs#967)

89825db

setup 0.8.0 (argoproj-labs#966)

11299b7

Replace ArgoCD v1alpha1 references with v1beta1 (argoproj-labs#975)

e928c0e

Signed-off-by: Siddhesh Ghadi <[email protected]>

feat: pick up argo cd v2.8.3 (argoproj-labs#993)

91bf131

Signed-off-by: iam-veeramalla <[email protected]>

fix: replace deprecated syntax in kustomization.yaml (argoproj-labs#1000

cd7a54b

) Signed-off-by: minchao <[email protected]>

Implemented service, servicemonitor and tlssecret

edf628d

Signed-off-by: Yi Cai <[email protected]>

Merge upstream

8ae82ac

Signed-off-by: Yi Cai <[email protected]>

Resolved some compiler errors

070d37b

Signed-off-by: Yi Cai <[email protected]>

bug: fix heathcheck subkey generation for resources with no group (ar…

64aa268

…goproj-labs#1013) * account for empty group during resource customization config subkey generation --------- Signed-off-by: Jaideep Rao <[email protected]>

Compiler error fix

08e13ec

Signed-off-by: Yi Cai <[email protected]>

Merge upstream in

8145317

Signed-off-by: Yi Cai <[email protected]>

Fixed compiler errors

ea6d317

Signed-off-by: Yi Cai <[email protected]>

Merge remote-tracking branch 'upstream/operator-redesign' into gitops…

997e66e

…-3125-implement-repo-server

Added partial unit tests

bbdfc82

Signed-off-by: Yi Cai <[email protected]>

ciiay changed the base branch from master to operator-redesign October 6, 2023 16:00

jaideepr97 added 8 commits January 27, 2024 15:28

Merge branch 'op-red-add-global-test-pkg' of github.com:jaideepr97/ar…

d2df6fa

…gocd-operator into operator-redesign-repo-server

rename argocd test reconciler

33a2660

Signed-off-by: Jaideep Rao <[email protected]>

Merge branch 'op-red-add-global-test-pkg' of github.com:jaideepr97/ar…

3ea68bd

…gocd-operator into operator-redesign-repo-server

wip add unit tests for repo-server

78b4729

Signed-off-by: Jaideep Rao <[email protected]>

update all references to updateifchanged

45b5300

Signed-off-by: Jaideep Rao <[email protected]>

fix merge conflicts

53c58c5

Signed-off-by: Jaideep Rao <[email protected]>

finish adding unit tests

7531759

Signed-off-by: Jaideep Rao <[email protected]>

add helper unit tests

bc27d5c

Signed-off-by: Jaideep Rao <[email protected]>

jaideepr97 changed the title ~~code-refactoring: Gitops 3125 implement repo server~~ code-refactoring: implement repo-server Jan 28, 2024

jaideepr97 added 20 commits January 28, 2024 09:09

add unit tests for resource deletion & trigger rollout

b2400f9

Signed-off-by: Jaideep Rao <[email protected]>

add resource helper & updated trigger rollout

1061a4f

Signed-off-by: Jaideep Rao <[email protected]>

modify scheme opt signature

923407a

Signed-off-by: Jaideep Rao <[email protected]>

add helpers

0cee249

Signed-off-by: Jaideep Rao <[email protected]>

remove unnecessary changes

3e5b614

Signed-off-by: Jaideep Rao <[email protected]>

undo unneccesary appset changes

32f7d12

Signed-off-by: Jaideep Rao <[email protected]>

add nil check for ss

e122612

Signed-off-by: Jaideep Rao <[email protected]>

fix merge conflicts

8b3c414

Signed-off-by: Jaideep Rao <[email protected]>

wip: add unit tests with mocks

e19bf16

Signed-off-by: Jaideep Rao <[email protected]>

add unit test for get args

6b5f94f

Signed-off-by: Jaideep Rao <[email protected]>

wip add deployment unit test

0deea83

Signed-off-by: Jaideep Rao <[email protected]>

add metrics suffix, generalize name generation logic

e68a478

Signed-off-by: Jaideep Rao <[email protected]>

Merge branch 'op-red-change-name-generator' of github.com:jaideepr97/…

b3e92cf

…argocd-operator into operator-redesign-repo-server

fix method signature

ba9f1f6

Signed-off-by: Jaideep Rao <[email protected]>

Merge branch 'op-red-change-name-generator' of github.com:jaideepr97/…

0320a5e

…argocd-operator into operator-redesign-repo-server

remove need for dedicated metrics suffix

9d90241

Signed-off-by: Jaideep Rao <[email protected]>

allow passing in existing resources to test fns for minor drift checks

4c8bb5f

Signed-off-by: Jaideep Rao <[email protected]>

finish unit tests

c4b5e23

Signed-off-by: Jaideep Rao <[email protected]>

add status reconciliation fns for all components, reconcile statuses …

3325406

…at end of cycle Signed-off-by: Jaideep Rao <[email protected]>

remove status reconciliation from repo-server reconciliation loop

108ecf4

Signed-off-by: Jaideep Rao <[email protected]>

jaideepr97 closed this Feb 1, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

code-refactoring: implement repo-server #1016

code-refactoring: implement repo-server #1016

ciiay commented Oct 6, 2023 •

edited by jaideepr97

Loading

code-refactoring: implement repo-server #1016

code-refactoring: implement repo-server #1016

Conversation

ciiay commented Oct 6, 2023 • edited by jaideepr97 Loading

ciiay commented Oct 6, 2023 •

edited by jaideepr97

Loading