-
Notifications
You must be signed in to change notification settings - Fork 169
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Upgrade to DataFusion 44.0.0 #1154
base: main
Are you sure you want to change the base?
Conversation
This reverts commit febc1f1.
Hmmm |
Yes, I think we should. There is a PR to fix in DF: apache/datafusion#13778 |
I have upgraded to latest DF and reinstated the miri checks. I'll keep this in draft until the RC is available later this week. |
I see the MIRI CI check fails: https://github.com/apache/datafusion-comet/actions/runs/12455101824/job/34767108969?pr=1154 I can reproduce the failure locally on this branch with this command (needs rust nightly) MIRIFLAGS="-Zmiri-disable-isolation" cargo +nightly miri test -p datafusion-comet -- test_unpack_dictionary_primitive I have an idea of what is wrong -- I am looking into this |
I found the issue: Working on a fix |
Update pin to DataFusion for 44 release
Which issue does this PR close?
N/A
Rationale for this change
Start updating in preparation for DF 44.0.0
What changes are included in this PR?
Hash
&PartialEq
for many expressions (due to changes in ImplementEq
,PartialEq
,Hash
fordyn PhysicalExpr
datafusion#13005)How are these changes tested?
Existing tests