Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Upgrade to DataFusion 44.0.0 #1154

Draft
wants to merge 41 commits into
base: main
Choose a base branch
from

Conversation

andygrove
Copy link
Member

@andygrove andygrove commented Dec 9, 2024

Which issue does this PR close?

N/A

Rationale for this change

Start updating in preparation for DF 44.0.0

What changes are included in this PR?

How are these changes tested?

Existing tests

@andygrove andygrove marked this pull request as ready for review December 11, 2024 15:48
@kazuyukitanimura
Copy link
Contributor

Stop running the test suite with miri

Hmmm
Since this is not an official release yet, should we wait for the miri fix?

@andygrove
Copy link
Member Author

Stop running the test suite with miri

Hmmm Since this is not an official release yet, should we wait for the miri fix?

Yes, I think we should. There is a PR to fix in DF: apache/datafusion#13778

@andygrove andygrove marked this pull request as draft December 18, 2024 18:59
@andygrove andygrove changed the title chore: Upgrade to latest DataFusion chore: Upgrade to latest DataFusion 44.0.0 Dec 18, 2024
@andygrove andygrove changed the title chore: Upgrade to latest DataFusion 44.0.0 chore: Upgrade to DataFusion 44.0.0 Dec 18, 2024
@andygrove
Copy link
Member Author

I have upgraded to latest DF and reinstated the miri checks. I'll keep this in draft until the RC is available later this week.

@alamb
Copy link
Contributor

alamb commented Dec 23, 2024

I have upgraded to latest DF and reinstated the miri checks. I'll keep this in draft until the RC is available later this week.

I see the MIRI CI check fails:

https://github.com/apache/datafusion-comet/actions/runs/12455101824/job/34767108969?pr=1154

I can reproduce the failure locally on this branch with this command (needs rust nightly)

MIRIFLAGS="-Zmiri-disable-isolation" cargo +nightly miri test -p datafusion-comet -- test_unpack_dictionary_primitive

I have an idea of what is wrong -- I am looking into this

@alamb
Copy link
Contributor

alamb commented Dec 23, 2024

alamb and others added 2 commits December 24, 2024 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants