Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test DataFusion 44.0.0 with Comet #13835

Closed
alamb opened this issue Dec 18, 2024 · 5 comments
Closed

Test DataFusion 44.0.0 with Comet #13835

alamb opened this issue Dec 18, 2024 · 5 comments
Assignees
Labels
enhancement New feature or request

Comments

@alamb
Copy link
Contributor

alamb commented Dec 18, 2024

Is your feature request related to a problem or challenge?

We are trying to make sure the upgrade experience for DataFusion is better and to do so we are hoping to improve the testsing of major downstream projects

For version 44.0.0 we would like to test with comet prior to release

Describe the solution you'd like

I would like to create a PR to test DataFusion comet with a pre-released version of DataFusion (pinned to the main branch)

Describe alternatives you've considered

No response

Additional context

@andygrove has done this in apache/datafusion-comet#1154

@alamb alamb added the enhancement New feature or request label Dec 18, 2024
@alamb
Copy link
Contributor Author

alamb commented Dec 22, 2024

Testing looks good from what I can tell ✅

@alamb alamb closed this as completed Dec 22, 2024
@andygrove
Copy link
Member

Reopening ... I upgraded to latest and disabled default features, enabled our miri checks again but they are still failing.

@andygrove andygrove reopened this Dec 22, 2024
@andygrove
Copy link
Member

error: unsupported operation: can't call foreign function `rust_psm_stack_pointer` on OS `linux`
    --> /home/runner/.cargo/registry/src/index.crates.io-1949cf8c6b5b557f/psm-0.1.24/src/lib.rs:319:14
     |
319  |     unsafe { rust_psm_stack_pointer() }
     |              ^^^^^^^^^^^^^^^^^^^^^^^^ can't call foreign function `rust_psm_stack_pointer` on OS `linux`
     ```

@alamb
Copy link
Contributor Author

alamb commented Dec 24, 2024

I found another issue when testing today:

@alamb
Copy link
Contributor Author

alamb commented Dec 24, 2024

Looks like we are good to go now: apache/datafusion-comet#1154

Screenshot 2024-12-24 at 6 55 42 PM

I am claiming success (again) 🤞

@alamb alamb closed this as completed Dec 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants