-
Notifications
You must be signed in to change notification settings - Fork 825
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update MSRVs to be accurate #6742
base: main
Are you sure you want to change the base?
Changes from 11 commits
96928c2
4ba624f
25001d9
26498f0
5b0f602
765c2f0
f17f4cf
4d6ffeb
bfe798d
3be0974
85806ee
ddd66af
35e9f98
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -122,24 +122,17 @@ jobs: | |
uses: ./.github/actions/setup-builder | ||
- name: Install cargo-msrv | ||
run: cargo install cargo-msrv | ||
- name: Downgrade arrow dependencies | ||
run: cargo update -p ahash --precise 0.8.7 | ||
- name: Check arrow | ||
working-directory: arrow | ||
run: cargo msrv --log-target stdout verify | ||
- name: Check parquet | ||
working-directory: parquet | ||
run: cargo msrv --log-target stdout verify | ||
- name: Check arrow-flight | ||
working-directory: arrow-flight | ||
run: cargo msrv --log-target stdout verify | ||
- name: Downgrade object_store dependencies | ||
working-directory: object_store | ||
# Necessary because tokio 1.30.0 updates MSRV to 1.63 | ||
# and url 2.5.1, updates to 1.67 | ||
run: | | ||
cargo update -p tokio --precise 1.29.1 | ||
cargo update -p url --precise 2.5.0 | ||
- name: Check object_store | ||
working-directory: object_store | ||
run: cargo msrv --log-target stdout verify | ||
- name: Check all packages | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This is awesome ❤️ |
||
run: | | ||
find . -mindepth 2 -name Cargo.toml | while read -r dir | ||
do | ||
echo "Checking package '$dir'" | ||
cargo msrv verify --manifest-path "$dir" || exit 1 | ||
done |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -53,4 +53,3 @@ crc = { version = "3.0", optional = true } | |
|
||
|
||
[dev-dependencies] | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -25,7 +25,7 @@ authors = ["Apache Arrow <[email protected]>"] | |
license = "Apache-2.0" | ||
keywords = [ "arrow" ] | ||
edition = "2021" | ||
rust-version = "1.62" | ||
rust-version = "1.70" | ||
publish = false | ||
|
||
[lib] | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -24,7 +24,7 @@ readme = "README.md" | |
description = "A generic object store interface for uniformly interacting with AWS S3, Google Cloud Storage, Azure Blob Storage and local files." | ||
keywords = ["object", "storage", "cloud"] | ||
repository = "https://github.com/apache/arrow-rs/tree/master/object_store" | ||
rust-version = "1.64.0" | ||
rust-version = "1.70.0" | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I'm surprised by this given we had CI checking this previously? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I double checked, and indeed you are right that Not sure what is going on. Pushed a change to revert There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I agree -- I think it was my mistake to push it to 1.64. Let's put it back to 1.62.1 |
||
|
||
[package.metadata.docs.rs] | ||
all-features = true | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ahash
's MSRV now is 1.60, so we don't need this downgrade anymore.