-
Notifications
You must be signed in to change notification settings - Fork 825
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update MSRVs to be accurate #6742
Open
itsjunetime
wants to merge
13
commits into
apache:main
Choose a base branch
from
itsjunetime:june/update_msrvs
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
96928c2
Update most MSRVs
itsjunetime 4ba624f
Make cargo-msrv verify every package in repo instead of just a select…
itsjunetime 25001d9
Add test to ensure workspace rust version is being used at least some…
itsjunetime 26498f0
Fix exit1 => exit 1
itsjunetime 5b0f602
Make arrow-flight work, at the very least, with 'cargo metadata'
itsjunetime 765c2f0
Fix arrow-flight/gen rust-version to make CI pass now
itsjunetime f17f4cf
Get rid of pretty msrv logging as it can't all be displayed
itsjunetime 4d6ffeb
Do '-mindepth 2' with find to prevent running cargo msrv on the works…
itsjunetime bfe798d
Use correct MSRV for object_store
alamb 3be0974
remove workspace msrv check
alamb 85806ee
Merge remote-tracking branch 'apache/master' into june/update_msrvs
alamb ddd66af
revert msrv
alamb 35e9f98
push object_store MSRV back down to 1.62.1
itsjunetime File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -122,24 +122,17 @@ jobs: | |
uses: ./.github/actions/setup-builder | ||
- name: Install cargo-msrv | ||
run: cargo install cargo-msrv | ||
- name: Downgrade arrow dependencies | ||
run: cargo update -p ahash --precise 0.8.7 | ||
- name: Check arrow | ||
working-directory: arrow | ||
run: cargo msrv --log-target stdout verify | ||
- name: Check parquet | ||
working-directory: parquet | ||
run: cargo msrv --log-target stdout verify | ||
- name: Check arrow-flight | ||
working-directory: arrow-flight | ||
run: cargo msrv --log-target stdout verify | ||
- name: Downgrade object_store dependencies | ||
working-directory: object_store | ||
# Necessary because tokio 1.30.0 updates MSRV to 1.63 | ||
# and url 2.5.1, updates to 1.67 | ||
run: | | ||
cargo update -p tokio --precise 1.29.1 | ||
cargo update -p url --precise 2.5.0 | ||
- name: Check object_store | ||
working-directory: object_store | ||
run: cargo msrv --log-target stdout verify | ||
- name: Check all packages | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This is awesome ❤️ |
||
run: | | ||
find . -mindepth 2 -name Cargo.toml | while read -r dir | ||
do | ||
echo "Checking package '$dir'" | ||
cargo msrv verify --manifest-path "$dir" || exit 1 | ||
done |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -53,4 +53,3 @@ crc = { version = "3.0", optional = true } | |
|
||
|
||
[dev-dependencies] | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -25,7 +25,7 @@ authors = ["Apache Arrow <[email protected]>"] | |
license = "Apache-2.0" | ||
keywords = [ "arrow" ] | ||
edition = "2021" | ||
rust-version = "1.62" | ||
rust-version = "1.70" | ||
publish = false | ||
|
||
[lib] | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ahash
's MSRV now is 1.60, so we don't need this downgrade anymore.