Add pagination to document collections search via title results page . #8359
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
farahTW
force-pushed
the
571-add-pagination-to-document-collections-results-page
branch
from
bed106b to
a20d30c
Compare
|
From screenshots it looks good. Lets setup a session today to go over the spacing :) |
|
What happens when there is only 1 to 15 search results returned? |
farahTW
force-pushed
the
571-add-pagination-to-document-collections-results-page
branch
2 times, most recently
from
1e59178 to
182ed7d
Compare
It will not render pagination component as it is handled to show pagination when records > 15 |
|
@nnagewad I have updated the message for no results found.Could you please check and let me know if it needs to be changed. |
farahTW
force-pushed
the
571-add-pagination-to-document-collections-results-page
branch
from
182ed7d to
adea239
Compare
farahTW
force-pushed
the
571-add-pagination-to-document-collections-results-page
branch
2 times, most recently
from
eaabd3a to
a4f6429
Compare
minhngocd
approved these changes
Oct 20, 2023
|
LGTM |
farahTW
force-pushed
the
571-add-pagination-to-document-collections-results-page
branch
from
a4f6429 to
35dc760
Compare
farahTW
deleted the
571-add-pagination-to-document-collections-results-page
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds pagination functionality to search via title results page to add document.
It does the following:
Trello:
https://trello.com/c/Idbzgryr/571-add-pagination-to-results-page-for-document-collections
Screen shots:
When no results found:
