Removed keyword slug from search via title.

alphagov · Oct 19, 2023 · a4f6429 · a4f6429
1 parent 615cd02
commit a4f6429
Show file tree

Hide file tree

Showing 5 changed files with 6 additions and 6 deletions.
diff --git a/app/controllers/admin/document_collection_group_document_search_controller.rb b/app/controllers/admin/document_collection_group_document_search_controller.rb
@@ -11,10 +11,10 @@ def search
       flash.now[:alert] = "Please select a search option"
       render :search_options
     end
-    redirect_to(action: :search_title_slug, document_collection_id: @collection, group_id: @group) if params[:search_option] == "title-or-slug"
+    redirect_to(action: :search_by_title, document_collection_id: @collection, group_id: @group) if params[:search_option] == "title"
   end
 
-  def search_title_slug
+  def search_by_title
     flash.now[:alert] = "Please enter a search query" if params[:title] && params[:title].empty?
     @editions = filter.editions if params[:title].present?
   end

diff --git a/...ocument_search/search_title_slug.html.erb → ..._document_search/search_by_title.html.erb b/...ocument_search/search_title_slug.html.erb → ..._document_search/search_by_title.html.erb
diff --git a/app/views/admin/document_collection_group_document_search/search_options.html.erb b/app/views/admin/document_collection_group_document_search/search_options.html.erb
@@ -15,7 +15,7 @@
       text: "Search via URL",
     },
     {
-      value: "title-or-slug",
+      value: "title",
       text: "Search via title",
     },
   ]

diff --git a/config/routes.rb b/config/routes.rb
@@ -34,7 +34,7 @@ def redirect(path, options = { prefix: Whitehall.router_prefix })
         resources :document_collection_groups, as: :groups, path: "groups" do
           get :search_options, to: "document_collection_group_document_search#search_options"
           post :search_options, to: "document_collection_group_document_search#search"
-          get :search_title_slug, to: "document_collection_group_document_search#search_title_slug"
+          get :search_by_title, to: "document_collection_group_document_search#search_by_title"
           member { get :confirm_destroy }
           resource :document_collection_group_membership,
                    as: :members,

diff --git a/test/functional/admin/legacy_document_collection_group_document_search_controller_test.rb b/test/functional/admin/legacy_document_collection_group_document_search_controller_test.rb
@@ -20,8 +20,8 @@ class Admin::LegacyDocumentCollectionGroupDocumentSearchControllerTest < ActionC
     assert_template :forbidden
   end
 
-  test "GET #search_title_slug blocks out users with no permissions" do
-    get :search_title_slug, params: @request_params
+  test "GET #search__by_title blocks out users with no permissions" do
+    get :search_by_title, params: @request_params
     assert_template :forbidden
   end
 end