forked from facebookincubator/velox
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Merge branch 'main' of https://github.com/acvictor/velox into acvicto…
…r/addAlias
- Loading branch information
Showing
66 changed files
with
1,853 additions
and
727 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,118 @@ | ||
| # Copyright (c) Facebook, Inc. and its affiliates. | ||
| # | ||
| # Licensed under the Apache License, Version 2.0 (the "License"); | ||
| # you may not use this file except in compliance with the License. | ||
| # You may obtain a copy of the License at | ||
| # | ||
| # http://www.apache.org/licenses/LICENSE-2.0 | ||
| # | ||
| # Unless required by applicable law or agreed to in writing, software | ||
| # distributed under the License is distributed on an "AS IS" BASIS, | ||
| # WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| # See the License for the specific language governing permissions and | ||
| # limitations under the License. | ||
|
|
||
| name: Collect Build Metrics | ||
|
|
||
| on: | ||
| pull_request: | ||
| paths: | ||
| - ".github/workflows/build-metrics.yml" | ||
|
|
||
| workflow_dispatch: | ||
| inputs: | ||
| ref: | ||
| description: "ref to check" | ||
| required: true | ||
|
|
||
| schedule: | ||
| # Run every day at 04:05 | ||
| - cron: "5 4 * * *" | ||
|
|
||
| permissions: | ||
| contents: read | ||
|
|
||
| jobs: | ||
| metrics: | ||
| name: Linux ${{ matrix.type }} with adapters | ||
| if: ${{ github.repository == 'facebookincubator/velox' }} | ||
| runs-on: ${{ matrix.runner }} | ||
| container: ghcr.io/facebookincubator/velox-dev:adapters | ||
| strategy: | ||
| fail-fast: false | ||
| matrix: | ||
| runner: ["16-core"] | ||
| type: ["debug", "release"] | ||
| defaults: | ||
| run: | ||
| shell: bash | ||
| env: | ||
| VELOX_DEPENDENCY_SOURCE: SYSTEM | ||
| simdjson_SOURCE: BUNDLED | ||
| xsimd_SOURCE: BUNDLED | ||
| steps: | ||
| - uses: actions/checkout@v4 | ||
| with: | ||
| ref: ${{ inputs.ref || github.sha }} | ||
|
|
||
| - name: Fix git permissions | ||
| # Usually actions/checkout does this but as we run in a container | ||
| # it doesn't work | ||
| run: git config --global --add safe.directory /__w/velox/velox | ||
|
|
||
| - name: Make ${{ matrix.type }} Build | ||
| env: | ||
| MAKEFLAGS: 'MAX_HIGH_MEM_JOBS=8 MAX_LINK_JOBS=4' | ||
| run: | | ||
| EXTRA_CMAKE_FLAGS=( | ||
| "-DVELOX_ENABLE_BENCHMARKS=ON" | ||
| "-DVELOX_ENABLE_ARROW=ON" | ||
| "-DVELOX_ENABLE_PARQUET=ON" | ||
| "-DVELOX_ENABLE_HDFS=ON" | ||
| "-DVELOX_ENABLE_S3=ON" | ||
| "-DVELOX_ENABLE_GCS=ON" | ||
| "-DVELOX_ENABLE_ABFS=ON" | ||
| "-DVELOX_ENABLE_REMOTE_FUNCTIONS=ON" | ||
| ) | ||
| make '${{ matrix.type }}' | ||
| - name: Log binary sizes | ||
| run: | | ||
| mkdir -p /tmp/metrics | ||
| sizes_file=/tmp/metrics/object_sizes | ||
| pushd '_build/${{ matrix.type }}' | ||
| find velox -type f -name '*.so' -o -name '*.a' -exec ls -l -BB {} \; | | ||
| awk '{print $5, $9; total += $5} END {print total," total_lib_size"}' > $sizes_file | ||
| find velox -type f -name '*.o' -exec ls -l -BB {} \; | | ||
| awk '{print $5, $9; total += $5} END {print total," total_obj_size"}' >> $sizes_file | ||
| find velox -type f -name 'velox_*' -exec ls -l -BB {} \; | | ||
| awk '{print $5, $9; total += $5} END {print total," total_exec_size"}' >> $sizes_file | ||
| - name: Copy ninja_log | ||
| run: cp _build/${{ matrix.type }}/.ninja_log /tmp/metrics/.ninja_log | ||
|
|
||
| - name: "Install dependencies" | ||
| run: | | ||
| python3 -m pip install setuptools | ||
| python3 -m pip install -r scripts/benchmark-requirements.txt | ||
| - name: "Upload Metrics" | ||
| env: | ||
| CONBENCH_URL: "https://velox-conbench.voltrondata.run/" | ||
| CONBENCH_MACHINE_INFO_NAME: "GitHub-runner-${{ matrix.runner }}" | ||
| CONBENCH_EMAIL: "${{ secrets.CONBENCH_EMAIL }}" | ||
| CONBENCH_PASSWORD: "${{ secrets.CONBENCH_PASSWORD }}" | ||
| # These don't actually work https://github.com/conbench/conbench/issues/1484 | ||
| # but have to be there to work regardless?? | ||
| CONBENCH_PROJECT_REPOSITORY: "${{ github.repository }}" | ||
| CONBENCH_PROJECT_COMMIT: "${{ inputs.ref || github.sha }}" | ||
| run: | | ||
| ./scripts/build-metrics.py upload \ | ||
| --build_type "${{ matrix.type }}" \ | ||
| --run_id "BM-${{ matrix.type }}-${{ github.run_id }}-${{ github.run_attempt }}" \ | ||
| --pr_number "${{ github.event.number }}" \ | ||
| --sha "${{ inputs.ref || github.sha }}" \ | ||
| "/tmp/metrics" |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
24 changes: 24 additions & 0 deletions
24
CMake/resolve_dependency_modules/libstemmer/Makefile.patch
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,24 @@ | ||
| # Copyright (c) Facebook, Inc. and its affiliates. | ||
| # | ||
| # Licensed under the Apache License, Version 2.0 (the "License"); | ||
| # you may not use this file except in compliance with the License. | ||
| # You may obtain a copy of the License at | ||
| # | ||
| # http://www.apache.org/licenses/LICENSE-2.0 | ||
| # | ||
| # Unless required by applicable law or agreed to in writing, software | ||
| # distributed under the License is distributed on an "AS IS" BASIS, | ||
| # WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| # See the License for the specific language governing permissions and | ||
| # limitations under the License. | ||
| --- a/Makefile | ||
| +++ b/Makefile | ||
| @@ -3,7 +3,7 @@ | ||
| EXEEXT=.exe | ||
| endif | ||
| CFLAGS=-O2 | ||
| -CPPFLAGS=-Iinclude | ||
| +CPPFLAGS=-Iinclude -fPIC | ||
| all: libstemmer.a stemwords$(EXEEXT) | ||
| libstemmer.a: $(snowball_sources:.c=.o) | ||
| $(AR) -cru $@ $^ |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,57 @@ | ||
| # Copyright (c) Facebook, Inc. and its affiliates. | ||
| # | ||
| # Licensed under the Apache License, Version 2.0 (the "License"); | ||
| # you may not use this file except in compliance with the License. | ||
| # You may obtain a copy of the License at | ||
| # | ||
| # http://www.apache.org/licenses/LICENSE-2.0 | ||
| # | ||
| # Unless required by applicable law or agreed to in writing, software | ||
| # distributed under the License is distributed on an "AS IS" BASIS, | ||
| # WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| # See the License for the specific language governing permissions and | ||
| # limitations under the License. | ||
| include_guard(GLOBAL) | ||
|
|
||
| set(VELOX_STEMMER_VERSION 2.2.0) | ||
| set(VELOX_STEMMER_BUILD_SHA256_CHECKSUM | ||
| b941d9fe9cf36b4e2f8d3873cd4d8b8775bd94867a1df8d8c001bb8b688377c3) | ||
| set(VELOX_STEMMER_SOURCE_URL | ||
| "https://snowballstem.org/dist/libstemmer_c-${VELOX_STEMMER_VERSION}.tar.gz" | ||
| ) | ||
|
|
||
| resolve_dependency_url(STEMMER) | ||
|
|
||
| message(STATUS "Building stemmer from source") | ||
| find_program(MAKE_PROGRAM make REQUIRED) | ||
|
|
||
| set(STEMMER_PREFIX "${CMAKE_BINARY_DIR}/_deps/libstemmer") | ||
| set(STEMMER_INCLUDE_PATH ${STEMMER_PREFIX}/src/libstemmer/include) | ||
|
|
||
| # We can not use FetchContent as libstemmer does not use cmake | ||
| ExternalProject_Add( | ||
| libstemmer | ||
| PREFIX ${STEMMER_PREFIX} | ||
| SOURCE_DIR ${STEMMER_PREFIX}/src/libstemmer | ||
| URL ${VELOX_STEMMER_SOURCE_URL} | ||
| URL_HASH ${VELOX_STEMMER_BUILD_SHA256_CHECKSUM} | ||
| BUILD_IN_SOURCE TRUE | ||
| CONFIGURE_COMMAND "" | ||
| BUILD_COMMAND ${MAKE_PROGRAM} | ||
| INSTALL_COMMAND "" | ||
| PATCH_COMMAND git apply ${CMAKE_CURRENT_LIST_DIR}/libstemmer/Makefile.patch | ||
| BUILD_BYPRODUCTS | ||
| ${STEMMER_PREFIX}/src/libstemmer/${CMAKE_STATIC_LIBRARY_PREFIX}stemmer${CMAKE_STATIC_LIBRARY_SUFFIX} | ||
| ) | ||
|
|
||
| add_library(stemmer STATIC IMPORTED) | ||
| add_library(stemmer::stemmer ALIAS stemmer) | ||
| file(MAKE_DIRECTORY ${STEMMER_INCLUDE_PATH}) | ||
| set_target_properties( | ||
| stemmer | ||
| PROPERTIES | ||
| IMPORTED_LOCATION | ||
| ${STEMMER_PREFIX}/src/libstemmer/${CMAKE_STATIC_LIBRARY_PREFIX}stemmer${CMAKE_STATIC_LIBRARY_SUFFIX} | ||
| INTERFACE_INCLUDE_DIRECTORIES ${STEMMER_INCLUDE_PATH}) | ||
|
|
||
| add_dependencies(stemmer libstemmer) |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.