Add alias getbit

acvictor · Apr 29, 2024 · f1aa4db · f1aa4db
1 parent 6c0bcb4
commit f1aa4db
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 4 deletions.
diff --git a/velox/docs/functions/spark/bitwise.rst b/velox/docs/functions/spark/bitwise.rst
@@ -41,6 +41,10 @@ Bitwise Functions
     The value of 'pos' argument must be between 0 and number of bits in 'x' - 1.
     Invalid 'pos' values result in an error.
 
+.. spark:function:: getbit(x, pos) -> tinyint
+
+    This is an alias for ``bit_get(x, pos)``.
+
 .. spark:function:: shiftleft(x, n) -> [same as x]
 
     Returns x bitwise left shifted by n bits. Supported types for 'x' are INTEGER and BIGINT.

diff --git a/velox/functions/sparksql/Bitwise.cpp b/velox/functions/sparksql/Bitwise.cpp
@@ -138,13 +138,13 @@ void registerBitwiseFunctions(const std::string& prefix) {
   registerFunction<BitCountFunction, int32_t, int64_t>({prefix + "bit_count"});
 
   registerFunction<BitGetFunction, int8_t, int8_t, int32_t>(
-      {prefix + "bit_get"});
+      {prefix + "bit_get", prefix + "getbit"});
   registerFunction<BitGetFunction, int8_t, int16_t, int32_t>(
-      {prefix + "bit_get"});
+      {prefix + "bit_get", prefix + "getbit"});
   registerFunction<BitGetFunction, int8_t, int32_t, int32_t>(
-      {prefix + "bit_get"});
+      {prefix + "bit_get", prefix + "getbit"});
   registerFunction<BitGetFunction, int8_t, int64_t, int32_t>(
-      {prefix + "bit_get"});
+      {prefix + "bit_get", prefix + "getbit"});
 
   registerFunction<ShiftLeftFunction, int32_t, int32_t, int32_t>(
       {prefix + "shiftleft"});