-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor pipeline to extract reusable basepipeline in module and library #1332
Closed
Closed
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
78fca3a
Move the BasePipeline parts into its own module
tdruez a0ce614
Refactor the Pipeline and Run system for re-usability
tdruez 6f5cf02
Package pipeline
keshav-space 104d784
Make pipeline work
keshav-space c661079
Add GitHub action to publish aboutcode-pipeline
keshav-space File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,44 @@ | ||
name: Build aboutcode-pipeline Python distributions and publish on PyPI | ||
|
||
on: | ||
workflow_dispatch: | ||
push: | ||
tags: | ||
- "pipeline-v*.*.*" | ||
|
||
jobs: | ||
build-and-publish: | ||
name: Build and publish library to PyPI | ||
runs-on: ubuntu-22.04 | ||
|
||
steps: | ||
- uses: actions/checkout@v4 | ||
|
||
- name: Set up Python | ||
uses: actions/setup-python@v5 | ||
with: | ||
python-version: 3.12 | ||
|
||
- name: Install flot | ||
run: python -m pip install flot --user | ||
|
||
- name: Build a binary wheel and a source tarball | ||
run: python -m flot --pyproject pyproject-pipeline.toml --sdist --wheel --output-dir dist/ | ||
|
||
- name: Publish to PyPI | ||
if: startsWith(github.ref, 'refs/tags') | ||
uses: pypa/gh-action-pypi-publish@release/v1 | ||
with: | ||
password: ${{ secrets.PYPI_API_TOKEN }} | ||
|
||
- name: Upload built archives | ||
uses: actions/upload-artifact@v4 | ||
with: | ||
name: pypi_archives | ||
path: dist/* | ||
|
||
- name: Create a GitHub release | ||
uses: softprops/action-gh-release@v1 | ||
with: | ||
draft: false | ||
files: dist/* |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,330 @@ | ||
# SPDX-License-Identifier: Apache-2.0 | ||
# | ||
# http://nexb.com and https://github.com/nexB/scancode.io | ||
# The ScanCode.io software is licensed under the Apache License version 2.0. | ||
# Data generated with ScanCode.io is provided as-is without warranties. | ||
# ScanCode is a trademark of nexB Inc. | ||
# | ||
# You may not use this software except in compliance with the License. | ||
# You may obtain a copy of the License at: http://apache.org/licenses/LICENSE-2.0 | ||
# Unless required by applicable law or agreed to in writing, software distributed | ||
# under the License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR | ||
# CONDITIONS OF ANY KIND, either express or implied. See the License for the | ||
# specific language governing permissions and limitations under the License. | ||
# | ||
# Data Generated with ScanCode.io is provided on an "AS IS" BASIS, WITHOUT WARRANTIES | ||
# OR CONDITIONS OF ANY KIND, either express or implied. No content created from | ||
# ScanCode.io should be considered or used as legal advice. Consult an Attorney | ||
# for any legal advice. | ||
# | ||
# ScanCode.io is a free software code scanning tool from nexB Inc. and others. | ||
# Visit https://github.com/nexB/scancode.io for support and download. | ||
|
||
import logging | ||
import traceback | ||
from pydoc import getdoc | ||
from pydoc import splitdoc | ||
from timeit import default_timer as timer | ||
|
||
from django.utils import timezone | ||
|
||
import bleach | ||
from markdown_it import MarkdownIt | ||
|
||
logger = logging.getLogger(__name__) | ||
|
||
|
||
""" | ||
Pipeline: steps definition, documentation | ||
Run: context (groups, steps), execution, logging, and results | ||
|
||
from pipeline import BasePipeline | ||
from pipeline import BasePipelineRun | ||
|
||
class DoSomething(BasePipeline, BasePipelineRun): | ||
@classmethod | ||
def steps(cls): | ||
return (cls.step1,) | ||
def step1(self): | ||
print("Message from step1") | ||
|
||
# 1. Run pipeline | ||
run = DoSomething() | ||
run.execute() | ||
|
||
# 2. Run pipeline with selected groups | ||
run = BasePipelineRun(selected_groups=["group1", "group2"]) | ||
run.execute() | ||
""" | ||
|
||
|
||
def group(*groups): | ||
"""Mark a function as part of a particular group.""" | ||
|
||
def decorator(obj): | ||
if hasattr(obj, "groups"): | ||
obj.groups = obj.groups.union(groups) | ||
else: | ||
setattr(obj, "groups", set(groups)) | ||
return obj | ||
|
||
return decorator | ||
|
||
|
||
def convert_markdown_to_html(markdown_text): | ||
"""Convert Markdown text to sanitized HTML.""" | ||
# Using the "js-default" for safety. | ||
html_content = MarkdownIt("js-default").renderInline(markdown_text) | ||
# Sanitize HTML using bleach. | ||
sanitized_html = bleach.clean(html_content) | ||
return sanitized_html | ||
|
||
|
||
def humanize_time(seconds): | ||
"""Convert the provided ``seconds`` number into human-readable time.""" | ||
message = f"{seconds:.0f} seconds" | ||
|
||
if seconds > 86400: | ||
message += f" ({seconds / 86400:.1f} days)" | ||
if seconds > 3600: | ||
message += f" ({seconds / 3600:.1f} hours)" | ||
elif seconds > 60: | ||
message += f" ({seconds / 60:.1f} minutes)" | ||
|
||
return message | ||
|
||
|
||
class LoopProgress: | ||
""" | ||
A context manager for logging progress in loops. | ||
|
||
Usage:: | ||
|
||
total_iterations = 100 | ||
logger = print # Replace with your actual logger function | ||
|
||
progress = LoopProgress(total_iterations, logger, progress_step=10) | ||
for item in progress.iter(iterator): | ||
"Your processing logic here" | ||
|
||
with LoopProgress(total_iterations, logger, progress_step=10) as progress: | ||
for item in progress.iter(iterator): | ||
"Your processing logic here" | ||
""" | ||
|
||
def __init__(self, total_iterations, logger, progress_step=10): | ||
self.total_iterations = total_iterations | ||
self.logger = logger | ||
self.progress_step = progress_step | ||
self.start_time = timer() | ||
self.last_logged_progress = 0 | ||
self.current_iteration = 0 | ||
|
||
def get_eta(self, current_progress): | ||
run_time = timer() - self.start_time | ||
return round(run_time / current_progress * (100 - current_progress)) | ||
|
||
@property | ||
def current_progress(self): | ||
return int((self.current_iteration / self.total_iterations) * 100) | ||
|
||
@property | ||
def eta(self): | ||
run_time = timer() - self.start_time | ||
return round(run_time / self.current_progress * (100 - self.current_progress)) | ||
|
||
def log_progress(self): | ||
reasons_to_skip = [ | ||
not self.logger, | ||
not self.current_iteration > 0, | ||
self.total_iterations <= self.progress_step, | ||
] | ||
if any(reasons_to_skip): | ||
return | ||
|
||
if self.current_progress >= self.last_logged_progress + self.progress_step: | ||
msg = ( | ||
f"Progress: {self.current_progress}% " | ||
f"({self.current_iteration}/{self.total_iterations})" | ||
) | ||
if eta := self.eta: | ||
msg += f" ETA: {humanize_time(eta)}" | ||
|
||
self.logger(msg) | ||
self.last_logged_progress = self.current_progress | ||
|
||
def __enter__(self): | ||
return self | ||
|
||
def __exit__(self, exc_type, exc_value, traceback): | ||
pass | ||
|
||
def iter(self, iterator): | ||
for item in iterator: | ||
self.current_iteration += 1 | ||
self.log_progress() | ||
yield item | ||
|
||
|
||
class BasePipelineRun: | ||
"""Base class for all pipeline run (execution).""" | ||
|
||
def __init__(self, selected_groups=None, selected_steps=None): | ||
"""Load the Pipeline class.""" | ||
self.pipeline_class = self.__class__ | ||
self.pipeline_name = self.pipeline_class.__name__ | ||
|
||
self.selected_groups = selected_groups | ||
self.selected_steps = selected_steps or [] | ||
|
||
self.execution_log = [] | ||
self.current_step = "" | ||
|
||
def append_to_log(self, message): | ||
self.execution_log.append(message) | ||
|
||
def set_current_step(self, message): | ||
self.current_step = message | ||
|
||
def log(self, message): | ||
"""Log the given `message` to the current module logger and Run instance.""" | ||
now_as_localtime = timezone.localtime(timezone.now()) | ||
timestamp = now_as_localtime.strftime("%Y-%m-%d %H:%M:%S.%f")[:-4] | ||
message = f"{timestamp} {message}" | ||
logger.info(message) | ||
self.append_to_log(message) | ||
|
||
@staticmethod | ||
def output_from_exception(exception): | ||
"""Return a formatted error message including the traceback.""" | ||
output = f"{exception}\n\n" | ||
|
||
if exception.__cause__ and str(exception.__cause__) != str(exception): | ||
output += f"Cause: {exception.__cause__}\n\n" | ||
|
||
traceback_formatted = "".join(traceback.format_tb(exception.__traceback__)) | ||
output += f"Traceback:\n{traceback_formatted}" | ||
|
||
return output | ||
|
||
def execute(self): | ||
"""Execute each steps in the order defined on this pipeline class.""" | ||
self.log(f"Pipeline [{self.pipeline_name}] starting") | ||
|
||
steps = self.pipeline_class.get_steps(groups=self.selected_groups) | ||
selected_steps = self.selected_steps | ||
|
||
steps_count = len(steps) | ||
pipeline_start_time = timer() | ||
|
||
for current_index, step in enumerate(steps, start=1): | ||
step_name = step.__name__ | ||
|
||
if selected_steps and step_name not in selected_steps: | ||
self.log(f"Step [{step_name}] skipped") | ||
continue | ||
|
||
self.set_current_step(f"{current_index}/{steps_count} {step_name}") | ||
self.log(f"Step [{step_name}] starting") | ||
step_start_time = timer() | ||
|
||
try: | ||
step(self) | ||
except Exception as exception: | ||
self.log("Pipeline failed") | ||
return 1, self.output_from_exception(exception) | ||
|
||
step_run_time = timer() - step_start_time | ||
self.log(f"Step [{step_name}] completed in {humanize_time(step_run_time)}") | ||
|
||
self.set_current_step("") # Reset the `current_step` field on completion | ||
pipeline_run_time = timer() - pipeline_start_time | ||
self.log(f"Pipeline completed in {humanize_time(pipeline_run_time)}") | ||
|
||
return 0, "" | ||
|
||
|
||
class BasePipeline: | ||
"""Base class for all pipeline implementations.""" | ||
|
||
# Flag indicating if the Pipeline is an add-on, meaning it cannot be run first. | ||
is_addon = False | ||
|
||
@classmethod | ||
def steps(cls): | ||
raise NotImplementedError | ||
|
||
@classmethod | ||
def get_steps(cls, groups=None): | ||
""" | ||
Return the list of steps defined in the ``steps`` class method. | ||
|
||
If the optional ``groups`` parameter is provided, only include steps labeled | ||
with groups that intersect with the provided list. If a step has no groups or | ||
if ``groups`` is not specified, include the step in the result. | ||
""" | ||
if not callable(cls.steps): | ||
raise TypeError("Use a ``steps(cls)`` classmethod to declare the steps.") | ||
|
||
steps = cls.steps() | ||
|
||
if groups is not None: | ||
steps = tuple( | ||
step | ||
for step in steps | ||
if not getattr(step, "groups", []) | ||
or set(getattr(step, "groups")).intersection(groups) | ||
) | ||
|
||
return steps | ||
|
||
@classmethod | ||
def get_doc(cls): | ||
"""Get the doc string of this pipeline.""" | ||
return getdoc(cls) | ||
|
||
@classmethod | ||
def get_graph(cls): | ||
"""Return a graph of steps.""" | ||
return [ | ||
{ | ||
"name": step.__name__, | ||
"doc": getdoc(step), | ||
"groups": getattr(step, "groups", []), | ||
} | ||
for step in cls.get_steps() | ||
] | ||
|
||
@classmethod | ||
def get_info(cls, as_html=False): | ||
"""Get a dictionary of combined information data about this pipeline.""" | ||
summary, description = splitdoc(cls.get_doc()) | ||
steps = cls.get_graph() | ||
|
||
if as_html: | ||
summary = convert_markdown_to_html(summary) | ||
description = convert_markdown_to_html(description) | ||
for step in steps: | ||
step["doc"] = convert_markdown_to_html(step["doc"]) | ||
|
||
return { | ||
"summary": summary, | ||
"description": description, | ||
"steps": steps, | ||
"available_groups": cls.get_available_groups(), | ||
} | ||
|
||
@classmethod | ||
def get_summary(cls): | ||
"""Get the doc string summary.""" | ||
return cls.get_info()["summary"] | ||
|
||
@classmethod | ||
def get_available_groups(cls): | ||
return sorted( | ||
set( | ||
group_name | ||
for step in cls.get_steps() | ||
for group_name in getattr(step, "groups", []) | ||
) | ||
) |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the "pipeline" module name needs to be changed to something better that will not conflict when installed with other libraries.
I suggest either:
using a namespace (we never did before, but we could start). This would mean creating a top level
aboutcode
directory with no__init__.py
and a few more details TBD. This is PEP420 https://peps.python.org/pep-0420/ and https://docs.python.org/3/glossary.html#term-namespace-package and this namespace would become reusable across other projects for shared modules. This is OK because we own aboutcode on PyPI and none of our projects ever used theaboutcode
module name. Some exmaples include jaraco's repos at https://github.com/jaraco/jaraco.vcs https://github.com/jaraco/jaraco.abode and https://github.com/jaraco/jaraco.context all living in the same "jaraco" namespace.In this case I would suggest that we call the package pipeline under aboutcode namespace. And end up with this path
aboutcode/pipeline/__init__.py
using another name for the package directory that contains
__init__.py
and use that as a regular, non-namespaced module. For instanceaboutcode_pipeline/__init__.py
There are no specific benefits nor issues with the second approach. Using the first approach with a namespace would be the pythonic way.
We should name the wheel
aboutcode.pipeline
to make it unique.