Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor pipeline to extract reusable basepipeline in module and library #1332

Closed
wants to merge 5 commits into from

Conversation

tdruez
Copy link
Contributor

@tdruez tdruez commented Jul 22, 2024

This PR refactors the pipelines architecture to extract a reusable BasePipeline in its own module and also available as standalone library

This is going to support adopting pipelines in VulnerableCode and PurlDB

Reference:

@keshav-space keshav-space force-pushed the base-pipeline-refactor branch from ac54f98 to 104d784 Compare August 6, 2024 08:11
@keshav-space keshav-space force-pushed the base-pipeline-refactor branch from ceeb581 to c661079 Compare August 6, 2024 18:20
@pombredanne pombredanne changed the title Base pipeline refactor Refactor pipeline to extract reusable basepipeline in module and library Aug 7, 2024
@tdruez
Copy link
Contributor Author

tdruez commented Aug 7, 2024

The code in this branch is currently experimental and not ready for merge/production.

@tdruez tdruez marked this pull request as draft August 7, 2024 10:25
@@ -0,0 +1,330 @@
# SPDX-License-Identifier: Apache-2.0
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the "pipeline" module name needs to be changed to something better that will not conflict when installed with other libraries.

I suggest either:

There are no specific benefits nor issues with the second approach. Using the first approach with a namespace would be the pythonic way.

We should name the wheel aboutcode.pipeline to make it unique.

@tdruez
Copy link
Contributor Author

tdruez commented Aug 8, 2024

This PR is already too complex combining the module refactoring, the Pipeline classes refactoring, packaging logic, and new CI for release publishing.

Let's split this into manageable and simpler-to-review parts:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants