-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Small changes to paradigm styles #864
base: main
Are you sure you want to change the base?
Conversation
Codecov Report
@@ Coverage Diff @@
## main #864 +/- ##
==========================================
+ Coverage 81.71% 81.76% +0.04%
==========================================
Files 106 106
Lines 4414 4414
Branches 650 650
==========================================
+ Hits 3607 3609 +2
+ Misses 684 681 -3
- Partials 123 124 +1
Continue to review full report at Codecov.
|
I will abstain from reviewing this, since I was there, but @aarppe, @andrewdotn, and @dwhieb, I'd appreciate your thoughts on these styling changes! |
Addresses #862. |
For separating the linguistic content from the meta-linguistic labels, bolding the latter does work well. But for distinguishing observed forms from merely generated ones, with italicizing the former, I'm not convinced that that formatting will achieve the goal. People might consider italics as lesser than regular, and think that the forms that are italicized are not observed, and not the other way around. Honestly, the old scheme of boldfacing observed forms in contrast to unobserved forms was self-evident. Of course, that conflicted with column/row labels, if we'd want to bold-face those to distinguish them clearly. I could imagine some options:
|
This is actually what the styling indicates. mîcisow is an unobserved form of “mîcisow”!
So I've had the discussion with many people: “what does the bolding mean?” and I've had to explicitly explain it to them. It is not self-evident. Plus, #405 still needs to be done that explicitly explains certain things, like the corpus frequencies.
We'll have to iterate on the design a bit more. I will continue to resist colouring text blue if it is not a link. Of course, with #405 finished, we could make it a link! |
I largely agree with @eddieantonio 's comments. I think blue should be reserved for links, unless we have another very clear colour we're using for links throughout morphodict/those items actually do link to something. Also, having black and grey text side by side does weird things to my eyes and my perception of colours--I often end up thinking they're the same colour and it just looks different based on whether I'm looking directly at the text. I think we have a lot of information to convey implicitly and getting this to a state where everyone automatically knows what's being presented is going to take multiple iterations |
I looked at the revision again. It does a good job in distinguishing the word-forms from the labels. But I have a really hard time distinguishing attested from unattested forms – the italicization really needs focus and is hard to discern. Weirdly, in some ways, I would that the current rendering is almost better, in that the row labels are consistently italicized, cf. If we must still with a single color, i.e. black, I'm not really sure what the best options are. Perhaps they would be the following:
Here are some alternative visualizations: |
What's in this PR:
It looks like this now: