Coin additions #895
Open
Coin additions #895
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Make coins use their own ID array in save files, instead of sharing the trinket ID array - Add coin editor entities to allow external tools to use coins, and help the game figure out when it should render the coin display - Unlimits the coin amount and stores it differently than other collectibles - Add `ifcoins` logic command to match trinkets - Add editor tool
Co-authored-by: Misa Elizabeth Kai <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds a few features, which don't¹ affect gameplay. It does the following:
[1] Technically, making coins use their own ID array no longer allows level makers to use
iftrinkets(x)to check if you've gotten coins, however the interaction between coins and trinkets made this hard to use anyway... I don't think any levels did this.[2] This PR adds coin editor entities, however it does not add a new editor tool. I personally just don't feel like I'm the one who should make such a big decision like adding a new tool.
Legal Stuff:
By submitting this pull request, I confirm that...
CONTRIBUTORSfile and the "GitHub Friends"section of the credits for all of said releases, but will NOT be compensated
for these changes