Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BugFix] fix cloud native index memtable memory calculation #54464

Merged
merged 1 commit into from
Dec 27, 2024

Conversation

luohaha
Copy link
Contributor

@luohaha luohaha commented Dec 27, 2024

Why I'm doing:

In previous PR #54358 , I change the memtable's memory_usage() function to:

size_t PersistentIndexMemtable::memory_usage() const {
-    return _keys_size + _map.size() * sizeof(IndexValueWithVer);
 +   return _map.bytes_used();
}

But I found that bytes_used() provide by btree map can't get the real memory usage.

What I'm doing:

Rollback to previous strategy first, will find out a better way later.

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.4
    • 3.3
    • 3.2
    • 3.1
    • 3.0

@luohaha luohaha requested a review from a team as a code owner December 27, 2024 11:01
@luohaha luohaha enabled auto-merge (squash) December 27, 2024 11:30
Copy link

[Java-Extensions Incremental Coverage Report]

pass : 0 / 0 (0%)

Copy link

[FE Incremental Coverage Report]

pass : 0 / 0 (0%)

Copy link

[BE Incremental Coverage Report]

pass : 1 / 1 (100.00%)

file detail

path covered_line new_line coverage not_covered_line_detail
🔵 be/src/storage/lake/persistent_index_memtable.cpp 1 1 100.00% []

@luohaha luohaha merged commit 42926be into StarRocks:main Dec 27, 2024
46 of 47 checks passed
Copy link

@Mergifyio backport branch-3.4

@github-actions github-actions bot removed the 3.4 label Dec 27, 2024
Copy link

@Mergifyio backport branch-3.3

@github-actions github-actions bot removed the 3.3 label Dec 27, 2024
Copy link
Contributor

mergify bot commented Dec 27, 2024

backport branch-3.4

✅ Backports have been created

Copy link
Contributor

mergify bot commented Dec 27, 2024

backport branch-3.3

✅ Backports have been created

@luohaha
Copy link
Contributor Author

luohaha commented Dec 27, 2024

https://github.com/Mergifyio backport branch-3.3.8

Copy link
Contributor

mergify bot commented Dec 27, 2024

backport branch-3.3.8

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Dec 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants