Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add check recordType XML element exists before referencing text #3825

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Add check recordType XML element exists before referencing text #3825

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
99de6c9
Add check recordType XML element exists before referencing text attri…
rtoepferveruna Sep 6, 2024
e5aa511
Merge branch 'main' into feature/pagelayout-norecordtype
rtoepferveruna Sep 13, 2024
a702679
Merge branch 'main' into feature/pagelayout-norecordtype
rtoepferveruna Sep 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions cumulusci/tasks/salesforce/update_profile.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -290,9 +290,10 @@ def _set_record_types(self, tree, api_name):
# Look for page layout definitions in the record type
found_layout = False
for elem in tree.findall("layoutAssignments"):
if elem.find("recordType").text == rt["record_type"]:
elem.layout.text = layout_option
found_layout = True
if elem.find("recordType") is not None:
if elem.find("recordType").text == rt["record_type"]:
elem.layout.text = layout_option
found_layout = True

if not found_layout:
assignment = tree.append(tag="layoutAssignments")
Expand Down
Loading