Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add check recordType XML element exists before referencing text #3825

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

rtoepferveruna
Copy link

@rtoepferveruna rtoepferveruna commented Sep 6, 2024

Certain objects in Salesforce profile XML schema are not required to have a recordType child element of layoutAssignment node. This fix prevents an exception being thrown when updating orgs with these objects in the profile metadata.

…bute for profiles without this child element
@rtoepferveruna rtoepferveruna requested a review from a team as a code owner September 6, 2024 22:47
Copy link

salesforce-cla bot commented Sep 6, 2024

Thanks for the contribution! Before we can merge this, we need @rtoepferveruna to sign the Salesforce Inc. Contributor License Agreement.

@jlantz
Copy link
Contributor

jlantz commented Sep 7, 2024

@jstvz I've reviewed this change, tested it locally, and implemented with @rtoepferveruna in a repo with active CI builds using CumulusCI. I can't see any risk to adding it as it current would be throwing an exception for anyone hitting the issue.

@jstvz jstvz added oss-contribution maintainer-approved Reviewed and approved by a community maintainer labels Sep 11, 2024
Copy link
Contributor

@jstvz jstvz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution, @rtoepferveruna

@jstvz jstvz enabled auto-merge (squash) September 24, 2024 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla:signed maintainer-approved Reviewed and approved by a community maintainer oss-contribution
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants