feat: use deployment for sentinel #36
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jiayouxujin
force-pushed
the
deployment-for-sentinel
branch
from
41a429b to
2ab9ad1
Compare
jiayouxujin
changed the title
jiayouxujin
force-pushed
the
deployment-for-sentinel
branch
from
c2aa11b to
b111a8c
Compare
jiayouxujin
force-pushed
the
deployment-for-sentinel
branch
from
4a33695 to
87a2474
Compare
ColinChamber
reviewed
Aug 1, 2023
deploy/crd/templates/crd.yaml
Outdated
| @@ -15,841 +15,1084 @@ spec: | |||
| singular: kvrocks | |||
| scope: Namespaced | |||
| versions: | |||
| - additionalPrinterColumns: | |||
There was a problem hiding this comment.
Would this file only have a few differences after rebasing and resolving conflicts? @jiayouxujin
ColinChamber
approved these changes
Aug 4, 2023
jiayouxujin
force-pushed
the
deployment-for-sentinel
branch
from
87a2474 to
554d228
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
This PR is for using deployment for sentinel.
Since the sentinel does not need to be a stateful service, we can use a deployment to deploy the sentinel. Meanwhile, the redis-operator also uses the same approach.
the related issues are #13 #37 #38 .