Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

In the standard type, the storage size of PVCs for Sentinel and KVrocks instances can only be the same. #37

Closed
ColinChamber opened this issue Jun 14, 2023 · 3 comments
Closed

In the standard type, the storage size of PVCs for Sentinel and KVrocks instances can only be the same. #37

ColinChamber opened this issue Jun 14, 2023 · 3 comments

Comments

@ColinChamber
Copy link
Contributor

The logic for creating PVCs between these two should be distinguished. Kvrocks instances may require larger storage size, but Sentinel does not.
@tianshimoyi
Copy link
Collaborator

Sentinel clusters do not require persistent storage

@jiayouxujin
Copy link
Collaborator

Thanks @tianshimoyi @ColinChamber
Now I've separated the code for kvrocks and sentinel. I'm using deployment to create sentinel, and using emptydir as the data volume.
https://github.com/RocksLabs/kvrocks-operator/pull/36/files#diff-46f6482b49eadbf34413755b425c88e4032c00027901225a4feacde6e78b9d44R62

@jiayouxujin jiayouxujin mentioned this issue Jun 29, 2023
Merged
@ColinChamber
Copy link
Contributor Author

Sentinel clusters do not require persistent storage

Before #36, when creating sentinels, it would call the NewStatefulSet function, which would require persistent storage.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jiayouxujin @tianshimoyi @ColinChamber