Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use kvSizeBits/kvEntrieBits instead of kvSize/kvEntries to init shard manager #149

Open
wants to merge 3 commits into
base: tm_w3q
Choose a base branch
from
Open

use kvSizeBits/kvEntrieBits instead of kvSize/kvEntries to init shard manager #149

wants to merge 3 commits into from

Conversation

ping-ke
Copy link

@ping-ke ping-ke commented May 10, 2023 •
edited
Loading

  • use kvSizeBits/kvEntrieBits instead of kvSize/kvEntries to init shard manager
  • change AddDataFileFromConfig format from --sstorage.file=4k,filename to --sstorage.file=filename
  • fix test cases

@ping-ke ping-ke requested review from qizhou, qzhodl and cyl19970726 May 10, 2023 15:14
@qizhou
Copy link

qizhou commented May 10, 2023 •
edited
Loading

I would recommend submitting the corresponding PR for go-ethstorage first, as go-ethstorage is our current main repo.

@ping-ke ping-ke mentioned this pull request May 16, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qizhou qizhou Awaiting requested review from qizhou

@qzhodl qzhodl Awaiting requested review from qzhodl

@cyl19970726 cyl19970726 Awaiting requested review from cyl19970726

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ping-ke @qizhou