make process-compose-flake usable without flake-parts #80
Conversation
flake.nix
Outdated
| @@ -3,6 +3,7 @@ | |||
| flakeModule = ./nix/flake-module.nix; | |||
|
|
|||
| lib = ./nix/lib.nix; | |||
| evalModules = import ./nix/eval-modules.nix; | |||
There was a problem hiding this comment.
Since lib already exists for this purpose, you want to put those two functions inside of it.
There was a problem hiding this comment.
What bugs me a bit about this is that if we put the functions inside lib, we first need to pass in "lib", and then pass in "pkgs" again which already has lib. This makes using the function a bit strange, but I can do it if you want.
There was a problem hiding this comment.
You can make the arguments of lib.nix module like this:
{ pkgs, lib ? pkgs.lib, ... }Then only one argument (the first) is non-optional.
There was a problem hiding this comment.
Ok, done. This is a breaking change, though.
nix/eval-modules.nix
Outdated
| @@ -0,0 +1,15 @@ | |||
| rec { | |||
| evalModules = { pkgs, name, modules }: (pkgs.lib.evalModules { | |||
There was a problem hiding this comment.
Could you document the function as a comment above? Here, and in makeProcessCompose function below.
|
Also, CI is failing. |
example/flake.nix
Outdated
| @@ -76,6 +76,25 @@ | |||
| }; | |||
| }; | |||
| }; | |||
|
|
|||
| # nix run .#ponysay up to start the process | |||
| packages.ponysay = (import ../nix/eval-modules.nix).makeProcessCompose { | |||
There was a problem hiding this comment.
This would look something like:
| packages.ponysay = (import ../nix/eval-modules.nix).makeProcessCompose { | |
| packages.ponysay = inputs.process-compose-flake.lib.makeProcessCompose { |
There was a problem hiding this comment.
Doesn't this mean that the example can only be run after pushing the code upstream? I think it's nice if it's possible to use the example while working on the code. But I can surely do it.
There was a problem hiding this comment.
I'll update the lock file after merging the PR, but in CI, it will always use latest, due to
process-compose-flake/flake.nix
Line 15 in f6ce948
There was a problem hiding this comment.
In the meanwhile, you can do cd ./example && nix run . --override-input process-compose-flake .. to test locally.
VanCoding
force-pushed
the
step1
branch
2 times, most recently
from
fd6ab97 to
d21af94
Compare
This didn't work for me, it still uses lib from upstream. But I assume it'll work now. |
|
@srid Nice!! Thanks for pulling that one in. :) |
See previous discussion in #79
followup PRs are in branches VanCoding:step2 and VanCoding:step3