Integrate Glam Onboarding Feature Flag #502
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #502 +/- ##
==========================================
+ Coverage 43.16% 43.18% +0.01%
==========================================
Files 362 363 +1
Lines 11094 11102 +8
Branches 1809 1809
==========================================
+ Hits 4789 4794 +5
- Misses 6143 6144 +1
- Partials 162 164 +2 ☔ View full report in Codecov by Sentry. |
crisnicandrei
approved these changes
Dec 9, 2024
|
This doesn't seem to be working on dev right now (I believe it is a configuration issue), so I will fix this before requesting QA. |
|
This should be ready for QA now. New changes did add some uncovered code, but as I've said before, module constructors are essentially the |
yeslikesolo
approved these changes
Dec 11, 2024
meisekimiu
force-pushed
the
glam-feature-flag
branch
from
44bd887 to
8e42097
Compare
This is mainly for use in development environments, where setting feature flags in local Stela can be a bit annoying. A secret loaded from the `.env` file can be used in place of fetching a feature flag from the back-end. It will not overwrite a value from the back-end so this is only a fallback method to set values not defined in Stela already. Also add the ability to store secrets with kebab-case formats. To actually get this to work, a dev will have to temporarily store the feature flag in the "optional secrets" file. I do not recommend actually comitting that change though. PER-9570: Integrate Glam Onboarding Feature Flag
Integrate the new FeatureFlagService into Glam Onboarding and replace checks with localStorage's `isGlam` key with the new `glam-onboarding` feature flag. PER-9570: Integrate Glam Onboarding Feature Flag
Include the FeatureFlagModule in the AppModule so that it's automatically loaded at the start of each page load. Do not pass in Authorization for fetching feature flags, since it's not needed and it seems slow on local environments. PER-9570: Integrate Glam Onboarding Feature Flag
The final feature-flag endpoint returns an object with an `items` field. Use this `items` value instead of expecting a bare array from the API.
This is something that was also different after the actual implementation of the Feature Flag endpoint. Previously we may have expected some disabled flags would still show up in the response but with a `globallyEnabled` flag set to false. The current endpoint just gives us a list of enabled flags.
meisekimiu
force-pushed
the
glam-feature-flag
branch
from
8e42097 to
6e1211d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of using
localStorage, Glam onboarding is now configured with a feature flag defined in the environment's database. Also let the Feature Flag service use environment variables as fallback to make it easier to test them in local or other ephemeral environments.Steps to Test:
To test this in local, you can add
glam-onboardingtooptional-secretsand.env, and restart the development server whenever the flag is changed. An empty string (or absent flag) is considered a disabled feature flag.