Do not check for globallyEnabled on Feature Flags

This is something that was also different after the actual
implementation of the Feature Flag endpoint. Previously we may have
expected some disabled flags would still show up in the response but
with a `globallyEnabled` flag set to false. The current endpoint just
gives us a list of enabled flags.

src/app/feature-flag/services/feature-flag-api.service.spec.ts

@@ -28,10 +28,7 @@ describe('FeatureFlagApiService', () => {
 
   it('can fetch feature flags from the back end', (done) => {
     const expectedFlags = {
-      items: [
-        { name: 'potato', globallyEnabled: true },
-        { name: 'tomato', globallyEnabled: true },
-      ],
+      items: [{ name: 'potato' }, { name: 'tomato' }],
     };
 
     service

src/app/feature-flag/services/feature-flag.service.spec.ts

@@ -60,14 +60,11 @@ describe('FeatureFlagService', () => {
   });
 
   it('should fetch from the API on init', async () => {
-    mockApi.flags = [
-      { name: 'api0', globallyEnabled: true },
-      { name: 'api1', globallyEnabled: false },
-    ];
+    mockApi.flags = [{ name: 'api0', globallyEnabled: true }, { name: 'api1' }];
     await service.fetchFromApi();
 
     expect(service.isEnabled('api0')).toBeTrue();
-    expect(service.isEnabled('api1')).toBeFalse();
+    expect(service.isEnabled('api1')).toBeTrue();
   });
 
   it('should fetch from Secrets on local environment', async () => {

src/app/feature-flag/services/feature-flag.service.ts

@@ -19,7 +19,7 @@ export class FeatureFlagService {
   public async fetchFromApi(): Promise<void> {
     try {
       const flags = await this.api.getFeatureFlags();
-      flags.forEach((flag) => this.set(flag.name, flag.globallyEnabled));
+      flags.forEach((flag) => this.set(flag.name, true));
     } catch {
       // Do nothing
     }

src/app/feature-flag/types/feature-flag.ts

@@ -2,5 +2,5 @@
 
 export interface FeatureFlag {
   name: string;
-  globallyEnabled: boolean;
+  globallyEnabled?: boolean;
 }