Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate the archive creation Pr #421

Merged
merged 3 commits into from
Jul 16, 2024

Conversation

crisnicandrei
Copy link
Contributor

This PR is a follow-up to the PR #1. It separates the archive creation feature into a separate PR.

This is #397 without rebranching from the new sign in page.

This PR is a follow-up to the PR #1. It separates the archive creation feature into a separate PR.
Copy link

codecov bot commented Jul 4, 2024

Codecov Report

Attention: Patch coverage is 69.86301% with 22 lines in your changes missing coverage. Please review.

Project coverage is 38.32%. Comparing base (929b5e0) to head (1d24e96).

Files Patch % Lines
...create-new-archive/create-new-archive.component.ts 44.44% 15 Missing ⚠️
...ype-screen/select-archive-type-screen.component.ts 68.75% 5 Missing ⚠️
...rary/components/form-input/form-input.component.ts 66.66% 0 Missing and 1 partial ⚠️
src/app/onboarding/utils/utils.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #421      +/-   ##
==========================================
+ Coverage   38.15%   38.32%   +0.16%     
==========================================
  Files         324      328       +4     
  Lines       10706    10769      +63     
  Branches     1772     1777       +5     
==========================================
+ Hits         4085     4127      +42     
- Misses       6476     6500      +24     
+ Partials      145      142       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@meisekimiu meisekimiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for doing this. I don't see any accidental changes that would effect production if this was merged 👍 . I don't think this PR needs QA, since any feedback can be done once each PR is merged and can take the form of additional tickets.

@crisnicandrei crisnicandrei merged commit 7e74fce into main Jul 16, 2024
4 checks passed
@crisnicandrei crisnicandrei deleted the PER-9567-redesign-create-archive-only branch July 16, 2024 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants