Per 9567 redesign create archive #397
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crisnicandrei
force-pushed
the
PER-9491-new-sign-in
branch
from
c7cb23f to
770ae03
Compare
- Changed the style of the progress chuncks in the onboarding component
crisnicandrei
force-pushed
the
PER-9567-redesign-create-archive
branch
from
428b5e9 to
281fd70
Compare
- Added a new component to handle the name archive screen - Added a new component to handle the select archive type screen - Added a new utils file to handle the logic for the onboarding process
I have created a way to enable or disable the new glam path using a variable from the localStorage
meisekimiu
approved these changes
May 31, 2024
yeslikesolo
approved these changes
Jun 7, 2024
crisnicandrei
force-pushed
the
PER-9491-new-sign-in
branch
from
af25eb6 to
4d28c6f
Compare
|
Superseded by #421 |
Changed the background of the auth page and the structure.
- Created the new sign in page (kept the old structure but used the new components from the new component library) - Some minor changes to the new components because without the design they looked done, but now they are more polished and ready for the design
New register page design + a new divider component
New forgot password page
Display the loading spinner and changed the mfa page design
Final design changes + some tests for the new sign in flow
Made the checkbox navigable using tab and selectable using enter and space keys.
-Added tests for the new checkbox functionality -Added the MessageService to the mfa component provider array
Added a border to the light button when being focused
Fixed the navigation for the buttons, and added outlines to them on focus
Added an underline to the forgot password link
PER-9488-glam-checkbox Implementation of the new checkbox component.
Changed the background of the auth page and the structure.
- Created the new sign in page (kept the old structure but used the new components from the new component library) - Some minor changes to the new components because without the design they looked done, but now they are more polished and ready for the design
New register page design + a new divider component
Handle terms decline: Go back to register screen and keep the checkbox unchecked.
Display the loading spinner and changed the mfa page design
Final design changes + some tests for the new sign in flow
-Added tests for the new checkbox functionality -Added the MessageService to the mfa component provider array
- Changed the margin of the title on the sign in pace (only on mobile view) - Added padding to the form on the forgot password page - Added another breakpoint to make the form larger at smaller breakpoints right before it hits tablet
- Created a new link variant for the button so it can be navigated using tab. - Moved the aria-label of the checkbox component.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is my pull request for the new create archive step, This adds the new design from firgma to the onboarding flow.
To test this, because I have added a way to disable or enable it, as per @meisekimiu request, go to your browser's console and run the following command:
localStorage.setItem('isGlam',true). The functionality is the same as previously implemented