Fixes #22
Merged
Fixes #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Orvid
approved these changes
Sep 29, 2023
nikitalita
commented
Sep 29, 2023
| @@ -52,16 +52,16 @@ bool CapricaReportingContext::isWarningEnabled(CapricaFileLocation /* location * | |||
| size_t CapricaReportingContext::getLocationLine(CapricaFileLocation location, size_t lastLineHint) { | |||
| if (!lineOffsets.size()) | |||
| CapricaReportingContext::logicalFatal("Unable to locate line at offset {}.", location.startOffset); | |||
| if (lastLineHint != 0) { | |||
There was a problem hiding this comment.
@Orvid I had to remove this because it was resulting in incorrect line numbers in the debug info; this was just for speed, correct?
There was a problem hiding this comment.
Yep, it was there purely for speed. If it's causing problems, removing it is fine.
Orvid
reviewed
Sep 30, 2023
| @@ -40,6 +40,10 @@ void PexFunctionBuilder::populateFunction(PexFunction* func, PexDebugFunctionInf | |||
| line = reportingContext.getLocationLine(l, line); | |||
| if (line > std::numeric_limits<uint16_t>::max()) | |||
| reportingContext.fatal(l, "The file has too many lines for the debug info to be able to map correctly!"); | |||
| // check that the line is larger than the previous one; if not, then set it to the previous one. | |||
| // Compiler does not like | |||
There was a problem hiding this comment.
Would it be reasonable to hide this behind an engine limit?
Also, this comment is incomplete.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.