-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initialize testing framework setup #902
Conversation
Codecov Report
@@ Coverage Diff @@
## dev #902 +/- ##
==========================================
- Coverage 78.64% 75.88% -2.77%
==========================================
Files 54 54
Lines 5132 5187 +55
==========================================
- Hits 4036 3936 -100
- Misses 1096 1251 +155
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
@lsetiawan: thanks for setting this up -- this looks great! @emiliom @b-reyes and I just discussed this and we decided:
|
I'll use this PR as a parking space for things to remember for our hack session:
|
I have verified that all tests passed locally. Not sure what's going on with the CI in the last few runs. Some of the failures seemed to be outside of the plotting tests. The plotting tests were the ones that more often had this type of intermittent problem. @emiliom : I think i'll wait until this last run finished and merge, regardless of whether everything passes, so that you can PR to this Update: actually I think something got messed up by the redo PRs. Maybe you could just have the branch on your fork until I resolve this? |
Alright. See https://github.com/emiliom/echopype/tree/test-convert-refactor. That branch was developed on the latest |
Overview
This PR adds a README to the
tests
directory, as well as moving things around to start setting up for a testing framework. Discussions will follow.