Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initialize testing framework setup #902

Merged
merged 2 commits into from
Dec 24, 2022

Conversation

lsetiawan
Copy link
Member

@lsetiawan lsetiawan commented Dec 14, 2022

Overview

This PR adds a README to the tests directory, as well as moving things around to start setting up for a testing framework. Discussions will follow.

@lsetiawan lsetiawan requested a review from leewujung December 14, 2022 18:35
@lsetiawan lsetiawan changed the title Initialize testing framework setup Initialize testing framework setup [WIP] Dec 14, 2022
echopype/tests/README.md Outdated Show resolved Hide resolved
@lsetiawan lsetiawan changed the title Initialize testing framework setup [WIP] Initialize testing framework setup Dec 14, 2022
@lsetiawan lsetiawan marked this pull request as ready for review December 14, 2022 23:11
@codecov-commenter
Copy link

codecov-commenter commented Dec 15, 2022

Codecov Report

Merging #902 (33cc4f2) into dev (f3ced32) will decrease coverage by 2.76%.
The diff coverage is 23.63%.

@@            Coverage Diff             @@
##              dev     #902      +/-   ##
==========================================
- Coverage   78.64%   75.88%   -2.77%     
==========================================
  Files          54       54              
  Lines        5132     5187      +55     
==========================================
- Hits         4036     3936     -100     
- Misses       1096     1251     +155     
Flag Coverage Δ
unittests 75.88% <23.63%> (-2.77%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
echopype/testing.py 27.58% <23.63%> (-72.42%) ⬇️
echopype/consolidate/api.py 25.80% <0.00%> (-67.75%) ⬇️
echopype/utils/coding.py 25.92% <0.00%> (-66.67%) ⬇️
echopype/utils/prov.py 34.78% <0.00%> (-60.87%) ⬇️
echopype/utils/io.py 68.24% <0.00%> (-16.90%) ⬇️
echopype/calibrate/env_params.py 89.47% <0.00%> (-3.51%) ⬇️
echopype/echodata/echodata.py 78.50% <0.00%> (-2.69%) ⬇️
echopype/convert/set_groups_base.py 91.24% <0.00%> (-2.19%) ⬇️
echopype/calibrate/calibrate_ek.py 93.30% <0.00%> (-0.71%) ⬇️
echopype/convert/utils/ek_raw_parsers.py 55.74% <0.00%> (-0.17%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@leewujung
Copy link
Member

@lsetiawan: thanks for setting this up -- this looks great!

@emiliom @b-reyes and I just discussed this and we decided:

  • we will not merge this PR until after the v0.6.4
  • but we will get together next Wednesday to take care of all the needed changes! 🚀

@leewujung
Copy link
Member

I'll use this PR as a parking space for things to remember for our hack session:

@emiliom emiliom added the tests label Dec 21, 2022
@leewujung leewujung changed the base branch from old_dev to dev December 23, 2022 06:42
@leewujung leewujung changed the base branch from dev to test-overhaul December 23, 2022 21:24
@leewujung
Copy link
Member

leewujung commented Dec 24, 2022

I have verified that all tests passed locally. Not sure what's going on with the CI in the last few runs. Some of the failures seemed to be outside of the plotting tests. The plotting tests were the ones that more often had this type of intermittent problem.

@emiliom : I think i'll wait until this last run finished and merge, regardless of whether everything passes, so that you can PR to this test-overhaul branch.

Update: actually I think something got messed up by the redo PRs. Maybe you could just have the branch on your fork until I resolve this?

@emiliom
Copy link
Collaborator

emiliom commented Dec 24, 2022

Update: actually I think something got messed up by the redo PRs. Maybe you could just have the branch on your fork until I resolve this?

Alright. See https://github.com/emiliom/echopype/tree/test-convert-refactor. That branch was developed on the latest dev as of Wednesday or early Thursday at the latest.

@leewujung leewujung merged commit 80e6e1d into OSOceanAcoustics:test-overhaul Dec 24, 2022
leewujung added a commit that referenced this pull request Dec 24, 2022
@lsetiawan lsetiawan deleted the testing branch January 6, 2023 22:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

4 participants