Refactor tests/convert tests #1025
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e with test_path and relying more directly on pathlib paths
…e there. Rename and simplify azfp convert tests, replacing azfp_path fixture with test_path, relying more directly on pathlib.
… fixture. Rename ek80 convert module and simplify tests, replacing ek80_path fixture with test_path and relying more directly on pathlib.
…d add new convert_time_encodings_params fixture for it. Rename source_target_locs convert module and simplify tests to rely more directly on pathlib (remove conversion to str).
|
I'll close this PR now, since this is very outdated and many tests have changed. We'll pick up the rest of tests structural overhaul in a later PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the work I did on 2022-12-22 during the echopype "hack day". At the time I couldn't merge it until #902 was merged, but I didn't realize that happened last December. I've updated it to work with the current
dev.Creating a PR now before my changes diverge too much from
devand become harder to merge.tests/convert/conftest.pymodule.*_integration.pywhen appropriate.convert_time_encodings_paramsfixture inconvert/conftest.pyto supporttest_convert_source_target_locs_integration.pystrand/or rely more directly on pathlib.DON'T REVIEW YET! I'm realizing that I may not have included all the changes I made.