[17.0][MIG] hr_employee_relative: Migration to 17.0 #1382

ppyczko · 2024-07-17T07:18:33Z

No description provided.

Currently translated at 100.0% (32 of 32 strings) Translation: hr-14.0/hr-14.0-hr_employee_relative Translate-URL: https://translation.odoo-community.org/projects/hr-14-0/hr-14-0-hr_employee_relative/pt_BR/

…iority)

Currently translated at 93.7% (30 of 32 strings) Translation: hr-14.0/hr-14.0-hr_employee_relative Translate-URL: https://translation.odoo-community.org/projects/hr-14-0/hr-14-0-hr_employee_relative/de/

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: hr-16.0/hr-16.0-hr_employee_relative Translate-URL: https://translation.odoo-community.org/projects/hr-16-0/hr-16-0-hr_employee_relative/

ppyczko · 2024-07-17T08:00:20Z

Module migrated to version 17.0

cc https://github.com/APSL 158255

@miquelalzanillas @lbarry-apsl @mpascuall @peluko00 @javierobcn @BernatObrador please review

Issue #1291

peluko00

LGTM, code review and tested in runboat

mpascuall

LGTM

BernatObrador

LGTM, code review and tested in runboat

Saran440 · 2024-07-19T14:24:39Z

/ocabot migration hr_employee_relative

OCA-git-bot · 2024-07-22T07:39:58Z

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

andres-pcg · 2024-09-03T18:31:00Z

Hey @pedrobaeza by any chance, do you know who is the maintainer or can you please help us out with this merge?

Thanks in advance.

Regards,

pedrobaeza · 2024-09-03T18:47:47Z

@Saran440 may help. I see controversial to strip the years float field to integer.

andres-pcg · 2024-09-03T20:39:07Z

Thanks you! @pedrobaeza .

@Saran440 your feedback is really important and welcomed here. So this PR can be merge. Thanks.

Saran440 · 2024-09-04T07:32:57Z

@andrp92 I think we should add separate fields to store age_year, age_month, and age_day to capture all details.
This way, we can accommodate any projects or countries that might require age in terms of months or days. (allow invisible it if not need)

What do you think?

However, I tested this module and it worked. 👍

andres-pcg · 2024-09-04T14:34:41Z

@Saran440 It sounds reasonable. However, please notice that it was already managed in a single field back in:

But yes, I think that can be improved. What do you think @ppyczko?

ppyczko · 2024-09-05T07:20:19Z

@Saran440 @andrp92 thank you for your feedback! I added the requested changes, let me know if there's anything else!

Saran440 · 2024-09-06T02:16:06Z

@ppyczko Could you split commit

[MIG] --> for standard migration
[ENH] --> for enhance field float to integer. we will can backport this commit.

Currently translated at 15.6% (5 of 32 strings) Translation: hr-16.0/hr-16.0-hr_employee_relative Translate-URL: https://translation.odoo-community.org/projects/hr-16-0/hr-16-0-hr_employee_relative/it/

Currently translated at 100.0% (32 of 32 strings) Translation: hr-16.0/hr-16.0-hr_employee_relative Translate-URL: https://translation.odoo-community.org/projects/hr-16-0/hr-16-0-hr_employee_relative/es/

Currently translated at 100.0% (32 of 32 strings) Translation: hr-16.0/hr-16.0-hr_employee_relative Translate-URL: https://translation.odoo-community.org/projects/hr-16-0/hr-16-0-hr_employee_relative/fr/

Currently translated at 100.0% (32 of 32 strings) Translation: hr-16.0/hr-16.0-hr_employee_relative Translate-URL: https://translation.odoo-community.org/projects/hr-16-0/hr-16-0-hr_employee_relative/pt_BR/

…eger fields

ppyczko · 2024-09-06T05:33:16Z

@Saran440 done, thanks!

pedrobaeza · 2024-09-06T06:13:59Z

/ocabot merge nobump

OCA-git-bot · 2024-09-06T06:14:05Z

This PR looks fantastic, let's merge it!
Prepared branch 17.0-ocabot-merge-pr-1382-by-pedrobaeza-bump-nobump, awaiting test results.

OCA-git-bot · 2024-09-06T06:18:36Z

Congratulations, your PR was merged at 44c086b. Thanks a lot for contributing to OCA. ❤️

alexey-pelykh and others added 16 commits July 17, 2024 07:50

[12.0][ADD] hr_employee_relative: alternative to hr_family

adbce81

[12.0][IMP] Add migration script hr_family -> hr_employee_relative

5156390

[12.0][IMP] Add phone number and job to hr_employee_relative

1dbe919

[IMP] hr_employee_relative: black, isort

3cbf15b

[13.0][MIG] hr_employee_relative

a95bec6

[UPD] Brainbean Apps => CorporateHub

7a462de

[14.0][MIG] hr_employee_relative

69417f3

Translated using Weblate (Portuguese (Brazil))

e45a187

Currently translated at 100.0% (32 of 32 strings) Translation: hr-14.0/hr-14.0-hr_employee_relative Translate-URL: https://translation.odoo-community.org/projects/hr-14-0/hr-14-0-hr_employee_relative/pt_BR/

[FIX] hr_employee_relative: Avoid W7940 (dangerous-view-replace-wo-pr…

e339053

…iority)

Translated using Weblate (German)

4e59503

Currently translated at 93.7% (30 of 32 strings) Translation: hr-14.0/hr-14.0-hr_employee_relative Translate-URL: https://translation.odoo-community.org/projects/hr-14-0/hr-14-0-hr_employee_relative/de/

[MIG] hr_employee_relative: Migration to 15.0

e645b7f

[16.0][MIG] hr_employee_relative: Migration to 16.0.

f7c9bde

[UPD] Update hr_employee_relative.pot

4bd4d3e

[UPD] README.rst

9a51daa

Update translation files

955975b

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: hr-16.0/hr-16.0-hr_employee_relative Translate-URL: https://translation.odoo-community.org/projects/hr-16-0/hr-16-0-hr_employee_relative/

Added translation using Weblate (Italian)

3120781

ppyczko mentioned this pull request Jul 17, 2024

Migration to version 17.0 #1291

Open

22 tasks

peluko00 approved these changes Jul 17, 2024

View reviewed changes

mpascuall approved these changes Jul 17, 2024

View reviewed changes

OCA-git-bot added the approved label Jul 17, 2024

BernatObrador approved these changes Jul 18, 2024

View reviewed changes

OCA-git-bot added this to the 17.0 milestone Jul 19, 2024

OCA-git-bot added the ready to merge label Jul 22, 2024

Saran440 approved these changes Sep 4, 2024

View reviewed changes

ppyczko force-pushed the 17.0-mig-hr_employee_relative branch 4 times, most recently from 1b93777 to b5eb869 Compare September 5, 2024 07:14

mymage and others added 8 commits September 6, 2024 07:16

Translated using Weblate (Italian)

ea5ed30

Currently translated at 15.6% (5 of 32 strings) Translation: hr-16.0/hr-16.0-hr_employee_relative Translate-URL: https://translation.odoo-community.org/projects/hr-16-0/hr-16-0-hr_employee_relative/it/

Translated using Weblate (Spanish)

d7947ae

Currently translated at 100.0% (32 of 32 strings) Translation: hr-16.0/hr-16.0-hr_employee_relative Translate-URL: https://translation.odoo-community.org/projects/hr-16-0/hr-16-0-hr_employee_relative/es/

[UPD] README.rst

2f99bf9

Translated using Weblate (French)

95114d5

Currently translated at 100.0% (32 of 32 strings) Translation: hr-16.0/hr-16.0-hr_employee_relative Translate-URL: https://translation.odoo-community.org/projects/hr-16-0/hr-16-0-hr_employee_relative/fr/

Translated using Weblate (Portuguese (Brazil))

1be96da

Currently translated at 100.0% (32 of 32 strings) Translation: hr-16.0/hr-16.0-hr_employee_relative Translate-URL: https://translation.odoo-community.org/projects/hr-16-0/hr-16-0-hr_employee_relative/pt_BR/

[IMP] hr_employee_relative: pre-commit auto fixes

a03e4dc

[MIG] hr_employee_relative: Migration to 17.0

56d340e

[ENH] hr_employee_relative: Enhance age float field into separate int…

df206b1

…eger fields

ppyczko force-pushed the 17.0-mig-hr_employee_relative branch from b5eb869 to df206b1 Compare September 6, 2024 05:30

OCA-git-bot added the bot is merging ⏳ label Sep 6, 2024

OCA-git-bot merged commit ed8d16e into OCA:17.0 Sep 6, 2024
7 checks passed

OCA-git-bot added merged 🎉 and removed bot is merging ⏳ labels Sep 6, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[17.0][MIG] hr_employee_relative: Migration to 17.0 #1382

[17.0][MIG] hr_employee_relative: Migration to 17.0 #1382

ppyczko commented Jul 17, 2024

ppyczko commented Jul 17, 2024 •

edited

Loading

peluko00 left a comment

mpascuall left a comment

BernatObrador left a comment

Saran440 commented Jul 19, 2024

OCA-git-bot commented Jul 22, 2024

andres-pcg commented Sep 3, 2024

pedrobaeza commented Sep 3, 2024

andres-pcg commented Sep 3, 2024

Saran440 commented Sep 4, 2024 •

edited

Loading

andres-pcg commented Sep 4, 2024 •

edited

Loading

ppyczko commented Sep 5, 2024

Saran440 commented Sep 6, 2024

ppyczko commented Sep 6, 2024

pedrobaeza commented Sep 6, 2024

OCA-git-bot commented Sep 6, 2024

OCA-git-bot commented Sep 6, 2024

[17.0][MIG] hr_employee_relative: Migration to 17.0 #1382

[17.0][MIG] hr_employee_relative: Migration to 17.0 #1382

Conversation

ppyczko commented Jul 17, 2024

ppyczko commented Jul 17, 2024 • edited Loading

peluko00 left a comment

Choose a reason for hiding this comment

mpascuall left a comment

Choose a reason for hiding this comment

BernatObrador left a comment

Choose a reason for hiding this comment

Saran440 commented Jul 19, 2024

OCA-git-bot commented Jul 22, 2024

andres-pcg commented Sep 3, 2024

pedrobaeza commented Sep 3, 2024

andres-pcg commented Sep 3, 2024

Saran440 commented Sep 4, 2024 • edited Loading

andres-pcg commented Sep 4, 2024 • edited Loading

ppyczko commented Sep 5, 2024

Saran440 commented Sep 6, 2024

ppyczko commented Sep 6, 2024

pedrobaeza commented Sep 6, 2024

OCA-git-bot commented Sep 6, 2024

OCA-git-bot commented Sep 6, 2024

ppyczko commented Jul 17, 2024 •

edited

Loading

Saran440 commented Sep 4, 2024 •

edited

Loading

andres-pcg commented Sep 4, 2024 •

edited

Loading