[MIG] hr_employee_relative: Migration to 17.0

hr_employee_relative/README.rst

@@ -65,6 +65,11 @@ Contributors
 -  Alberto Nieto de Pablos <[email protected]>
    (https://braintec.com)
 
+-  `APSL-Nagarro <https://apsl.tech>`__:
+
+   -  Patryk Pyczko [email protected]
+   -  Bernat Obrador [email protected]
+
 Maintainers
 -----------
 

hr_employee_relative/__manifest__.py

@@ -4,7 +4,7 @@
 
 {
     "name": "HR Employee Relatives",
-    "version": "16.0.1.0.0",
+    "version": "17.0.1.0.0",
     "category": "Human Resources",
     "website": "https://github.com/OCA/hr",
     "author": "CorporateHub, Odoo Community Association (OCA)",

hr_employee_relative/models/hr_employee_relative.py

@@ -23,7 +23,9 @@ class HrEmployeeRelative(models.Model):
         selection=[("male", "Male"), ("female", "Female"), ("other", "Other")],
     )
     date_of_birth = fields.Date()
-    age = fields.Float(compute="_compute_age")
+    age_year = fields.Integer(string="Age (Years)", compute="_compute_age")
+    age_month = fields.Integer(string="Age (Months)")
+    age_day = fields.Integer(string="Age (Days)")
 
     job = fields.Char()
     phone_number = fields.Char()
@@ -33,8 +35,15 @@ class HrEmployeeRelative(models.Model):
     @api.depends("date_of_birth")
     def _compute_age(self):
         for record in self:
-            age = relativedelta(datetime.now(), record.date_of_birth)
-            record.age = age.years + (age.months / 12)
+            if record.date_of_birth:
+                age = relativedelta(datetime.now(), record.date_of_birth)
+                record.age_year = age.years
+                record.age_month = age.months
+                record.age_day = age.days
+            else:
+                record.age_year = 0
+                record.age_month = 0
+                record.age_day = 0
 
     @api.onchange("partner_id")
     def _onchange_partner_id(self):

hr_employee_relative/readme/CONTRIBUTORS.md

@@ -4,3 +4,6 @@
 - Nattapong W. \<<[email protected]>\>
 - Alberto Nieto de Pablos \<<[email protected]>\>
   (<https://braintec.com>)
+* [APSL-Nagarro](<https://apsl.tech>):
+  * Patryk Pyczko <[email protected]>
+  * Bernat Obrador <[email protected]>

hr_employee_relative/static/description/index.html

@@ -410,6 +410,11 @@ <h2><a class="toc-backref" href="#toc-entry-4">Contributors</a></h2>
 <li>Nattapong W. &lt;<a class="reference external" href="mailto:aphon61bank&#64;gmail.com">aphon61bank&#64;gmail.com</a>&gt;</li>
 <li>Alberto Nieto de Pablos &lt;<a class="reference external" href="mailto:alberto.nieto&#64;braintec.com">alberto.nieto&#64;braintec.com</a>&gt;
 (<a class="reference external" href="https://braintec.com">https://braintec.com</a>)</li>
+<li><a class="reference external" href="https://apsl.tech">APSL-Nagarro</a>:<ul>
+<li>Patryk Pyczko <a class="reference external" href="mailto:ppyczko&#64;apsl.net">ppyczko&#64;apsl.net</a></li>
+<li>Bernat Obrador <a class="reference external" href="mailto:bobrador&#64;apsl.net">bobrador&#64;apsl.net</a></li>
+</ul>
+</li>
 </ul>
 </div>
 <div class="section" id="maintainers">

hr_employee_relative/tests/test_hr_employee_relatives.py

@@ -9,13 +9,16 @@
 
 
 class TestHrEmployeeRelatives(common.TransactionCase):
-    def setUp(self):
-        super().setUp()
-        self.Employee = self.env["hr.employee"]
-        self.EmployeeRelative = self.env["hr.employee.relative"]
-        self.relation_sibling = self.env.ref("hr_employee_relative.relation_sibling")
+    @classmethod
+    def setUpClass(cls):
+        super().setUpClass()
+        cls.Employee = cls.env["hr.employee"]
+        cls.EmployeeRelative = cls.env["hr.employee.relative"]
+        cls.relation_sibling = cls.env.ref("hr_employee_relative.relation_sibling")
+        cls.partner_1 = cls.env.ref("base.res_partner_1")
+        cls.partner_2 = cls.env.ref("base.res_partner_2")
 
-    def test_age_calculation(self):
+    def create_relative(self, dob):
         employee = self.Employee.create(
             {
                 "name": "Employee",
@@ -25,19 +28,37 @@ def test_age_calculation(self):
                         0,
                         {
                             "relation_id": self.relation_sibling.id,
-                            "partner_id": self.env.ref("base.res_partner_1").id,
+                            "partner_id": self.partner_1.id,
                             "name": "Relative",
-                            "date_of_birth": datetime.now() + relativedelta(years=-42),
+                            "date_of_birth": dob,
                         },
                     )
                 ],
             }
         )
-        relative = self.EmployeeRelative.browse(employee.relative_ids[0].id)
-        self.assertEqual(int(relative.age), 42)
+        return self.EmployeeRelative.browse(employee.relative_ids[0].id)
+
+    def test_age_calculation_with_dob(self):
+        dob = datetime.now() + relativedelta(years=-42, months=-3, days=-15)
+        relative = self.create_relative(dob)
+
+        expected_age = relativedelta(datetime.now(), dob)
+
+        self.assertEqual(relative.age_year, expected_age.years)
+        self.assertEqual(relative.age_month, expected_age.months)
+        self.assertEqual(relative.age_day, expected_age.days)
         self.assertEqual(relative.name, "Relative")
-        # onchange partner
+
+        # Test onchange partner
         with Form(relative) as f:
-            f.partner_id = self.env.ref("base.res_partner_2")
+            f.partner_id = self.partner_2
             f.relation_id = self.relation_sibling
         self.assertEqual(relative.name, relative.partner_id.display_name)
+
+    def test_age_calculation_without_dob(self):
+        relative = self.create_relative(False)
+
+        self.assertEqual(relative.age_year, 0)
+        self.assertEqual(relative.age_month, 0)
+        self.assertEqual(relative.age_day, 0)
+        self.assertEqual(relative.name, "Relative")

hr_employee_relative/views/hr_employee_relative.xml

@@ -14,7 +14,9 @@
                 <field name="partner_id" />
                 <field name="gender" />
                 <field name="date_of_birth" />
-                <field name="age" />
+                <field name="age_year" string="Age (Years)" />
+                <field name="age_month" string="Age (Months)" optional="hide" />
+                <field name="age_day" string="Age (Days)" optional="hide" />
                 <field name="phone_number" />
                 <field name="job" />
                 <field name="notes" />