Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix mps deployment #505

Merged
merged 2 commits into from
Feb 7, 2024
Merged

Fix mps deployment #505

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4845769
Make MPS daemonset conditional
elezar Feb 6, 2024
31214a5
Fix MPS mount for device plugin
elezar Feb 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion deployments/helm/nvidia-device-plugin/templates/daemonset-device-plugin.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -186,7 +186,6 @@ spec:
# This is required for CDI detection to work correctly.
- name: driver-root
mountPath: /driver-root
readOnly: true
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Question -- why is this no longer read only?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The issue is that the mount to /driver-root/mps fails if this is a readonly path.

Do you have suggestions on how we can get around this?

{{- end }}
# The MPS /dev/shm is needed to allow for MPS daemon health-checking.
- name: mps-shm
Expand All @@ -213,6 +212,7 @@ spec:
hostPath:
# TODO: This should be /var/run/nvidia/mps
path: /var/lib/kubelet/device-plugins/mps
type: DirectoryOrCreate
- name: mps-shm
hostPath:
path: /var/lib/kubelet/device-plugins/mps/shm
Expand Down
2 changes: 2 additions & 0 deletions deployments/helm/nvidia-device-plugin/templates/daemonset-mps-control-daemon.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
# See the License for the specific language governing permissions and
# limitations under the License.
{{- if .Values.devicePlugin.enabled }}
---
{{- $hasConfigMap := (include "nvidia-device-plugin.hasConfigMap" .) | trim }}
{{- $configMapName := (include "nvidia-device-plugin.configMapName" .) | trim }}
Expand Down Expand Up @@ -224,3 +225,4 @@ spec:
tolerations:
{{- toYaml . | nindent 8 }}
{{- end }}
{{- end }}
Loading